fix(auth): fix isAuthenticatedOrRefresh to not refresh token with n…
#708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnixaa
force-pushed
the
fix/is-auth-invalid-token
branch
from
b64537b to
28ec4d9
Compare
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 72.96% 73.18% +0.22%
==========================================
Files 179 176 -3
Lines 4867 4800 -67
Branches 368 367 -1
==========================================
- Hits 3551 3513 -38
+ Misses 1244 1215 -29
Partials 72 72 |
| @@ -51,7 +51,7 @@ export class NbAuthService { | |||
| return this.getToken() | |||
| .pipe( | |||
| switchMap(token => { | |||
| if (!token.isValid()) { | |||
| if (!token.isValid() && token.getValue()) { | |||
There was a problem hiding this comment.
if (token.getValue() && !token.isValid())
makes more sense according to me (and maybe better performance ?)
|
@nnixaa i agree with the code you wrote. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #687