Changed OnInit to AfterViewInit for accordion-item-body component.

[Ballpin]

This will give the component a chance to get the right height when
elements are being retrieved from REST API's or when other components
are involved.

[codecov]

Codecov Report

Merging #726 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #726   +/-   ##
=======================================
  Coverage   76.01%   76.01%           
=======================================
  Files         192      192           
  Lines        5291     5291           
  Branches      399      399           
=======================================
  Hits         4022     4022           
  Misses       1184     1184           
  Partials       85       85

Impacted Files	Coverage Δ
...ponents/accordion/accordion-item-body.component.ts	50% <100%> (ø)	⬆️

[nnixaa]

Hi @Ballpin, thanks for the PR! I presume this won't work in case when the content is dynamically changed in runtime? Should we change it to onChanges?

[Ballpin]

Thank you @nnixaa for being of the devs creating nebular it's making wonders for me. :-)

I believe you are right on that part. For me it worked very well when a resolver was involved and prefetched the content. I could even use <nb user></nb-user> inside the accordion. A few hours later after submitting this PR, I noticed when you click at the "item-header" and expect the new content, it sticks to 35px height (or 1 rem to be exact).

Yes, change to onChanges if that works better.

[nnixaa]

Hey @Ballpin, thanks for your kind words! Would you like to complete this PR by changing this calculation to onChanges so that you are able to check whether it is working correctly in your usecase?

[Ballpin]

Hi @nnixaa i tried to do it for several hours yesterday without success. Unfortunately i ended up with removing the animation instead for my use case.

If you succeed it would be awesome. :)

[nnixaa]

Fixed in #882