Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): add type button, stop forms submitting #945

Merged
merged 2 commits into from
Oct 29, 2018

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Oct 26, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #877

@Tibing Tibing requested review from nnixaa and yggg October 26, 2018 10:03
@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #945 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #945   +/-   ##
=====================================
  Coverage      77%    77%           
=====================================
  Files         200    200           
  Lines        5948   5948           
  Branches      452    452           
=====================================
  Hits         4580   4580           
  Misses       1262   1262           
  Partials      106    106
Impacted Files Coverage Δ
...me/components/toastr/toastr-container.component.ts 65.38% <0%> (ø) ⬆️

@nnixaa nnixaa merged commit 255fca9 into akveo:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid nb-select behavior
2 participants