Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit row data on hover. #262

Merged
merged 9 commits into from
Mar 29, 2017
Merged

Emit row data on hover. #262

merged 9 commits into from
Mar 29, 2017

Conversation

vvandoorne
Copy link
Contributor

We changed the tbody emitter mouseover to rowEmitter to avoid confusion with the DOM event. Also, we needed to add an emitter to the ng2-smart-table component to "bubble up" the row to our code. We tested the code and we are able to get the row data in our components.

@bis-sb
Copy link
Contributor

bis-sb commented Mar 29, 2017

This was a correction to the previous PR

@lexzhukov
Copy link
Contributor

@vvandoorne could you resolve merge conflicts?

@vvandoorne
Copy link
Contributor Author

vvandoorne commented Mar 29, 2017 via email

@bis-sb
Copy link
Contributor

bis-sb commented Mar 29, 2017

Resolved -- it was just a name change to the event in the tbody component which somehow git thought was a conflict

@lexzhukov lexzhukov merged commit 68b73ee into akveo:master Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants