Only perform filter if search string is present #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bylertall
force-pushed
the
no-filter-on-empty-search
branch
from
f4ce31b
to
7c620b3
Compare
|
@bylertall Nice! |
|
Hi @bylertall, many thanks for your PR. Currently, we are also looking into the performance issues, so may use your PR as a part of our refactoring. |
|
@nnixaa Awesome, thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Column filters are run regardless of whether or not search input has been provided by the user. For example, on bootstrap of the example app provided in this repo,
localFilter.filtermethod is run 110 times.Solution
When looping through each filter, check
fieldConf['search']and only filter the data if a search string is present.