Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #1435 #1444

Merged
merged 6 commits into from
Jun 15, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/ui/autocomplete/autocomplete.component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,14 @@ export class Autocomplete extends React.Component<AutocompleteProps, State> {
};

public render(): PopoverElement {
const { placement, children, ...inputProps } = this.props;
const { placement, children, testID, ...inputProps } = this.props;

return (
<Popover
ref={this.popoverRef}
style={styles.popover}
placement={placement}
testID={testID}
visible={this.state.listVisible}
fullWidth={true}
anchor={() => this.renderInputElement(inputProps)}
Expand Down
5 changes: 4 additions & 1 deletion src/components/ui/datepicker/baseDatepicker.component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ export abstract class BaseDatepickerComponent<P, D = Date> extends React.Compone
const {
eva,
style,
testID,
backdropStyle,
controlStyle,
placement,
Expand All @@ -242,7 +243,9 @@ export abstract class BaseDatepickerComponent<P, D = Date> extends React.Compone
const evaStyle = this.getComponentStyle(eva.style);

return (
<View style={style}>
<View
style={style}
testID={testID}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the formatting

<FalsyText
style={[evaStyle.label, styles.label]}
component={label}
Expand Down
2 changes: 2 additions & 0 deletions src/components/ui/input/input.component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -254,13 +254,15 @@ export class Input extends React.Component<InputProps> implements WebEventRespon
caption,
accessoryLeft,
accessoryRight,
testID,
...textInputProps
} = this.props;

const evaStyle = this.getComponentStyle(eva.style);

return (
<TouchableWithoutFeedback
testID={testID}
style={evaStyle.container}
onPress={this.focus}>
<FalsyText
Expand Down
1 change: 1 addition & 0 deletions src/components/ui/select/select.component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,7 @@ export class Select extends React.Component<SelectProps, State> {

return (
<TouchableWeb
testID={props.testID}
style={[styles.input, evaStyle.input]}
onPress={this.onPress}
onMouseEnter={this.onMouseEnter}
Expand Down
2 changes: 1 addition & 1 deletion src/components/ui/spinner/spinner.component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export class Spinner extends React.PureComponent<SpinnerProps> {
const evaStyle = this.getComponentStyle(this.animation.toProps());

return (
<View style={containerSize}>
<View testID={this.props.testID} style={containerSize}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiline

{this.renderArcElement(evaStyle.start, containerSize)}
{this.renderArcElement(evaStyle.end, containerSize)}
</View>
Expand Down
4 changes: 2 additions & 2 deletions src/components/ui/tab/tabBar.component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -180,12 +180,12 @@ export class TabBar extends React.Component<TabBarProps> {
};

public render(): React.ReactElement<ViewProps> {
const { eva, style, indicatorStyle, selectedIndex, children, ...viewProps } = this.props;
const { eva, style, testID, indicatorStyle, selectedIndex, children, ...viewProps } = this.props;
const evaStyle = this.getComponentStyle(eva.style);
const tabElements: TabElement[] = this.renderTabElements(children);

return (
<View>
<View testID={testID}>
<View
{...viewProps}
style={[evaStyle.container, styles.container, style]}>
Expand Down
3 changes: 2 additions & 1 deletion src/components/ui/toggle/toggle.component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -370,11 +370,12 @@ export class Toggle extends React.Component<ToggleProps> implements PanResponder
};

public render(): React.ReactElement<ViewProps> {
const { eva, style, checked, children, ...touchableProps } = this.props;
const { eva, style, checked, children, testID, ...touchableProps } = this.props;
const evaStyle = this.getComponentStyle(eva.style);

return (
<View
testID={testID}
{...this.panResponder.panHandlers}
style={[styles.container, style]}>
<TouchableWeb
Expand Down