Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): tooltip component. Closes #261 #263

Merged
merged 11 commits into from
Feb 26, 2019
Merged

feat(ui): tooltip component. Closes #261 #263

merged 11 commits into from
Feb 26, 2019

Conversation

artyorsh
Copy link
Collaborator

@artyorsh artyorsh commented Feb 5, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

  • Implements Popover and Tooltip components

NOTES

During ui test implementation discovered that there is no way to test react element measurements.
So currently there are no ui tests, but I've covered models.

@artyorsh
Copy link
Collaborator Author

artyorsh commented Feb 8, 2019

Used force-push to remove commits with bug fixes in module resolution for ApplicationProvider which are implemented in #264

@malashkevich
Copy link
Member

  • render prop for popover
  • mappings for popover
  • tooltip should have mappings for popover and text
  • tooltip should have icon ?
  • comment the code, especially calculations
  • export placements as object + refactoring

@32penkin 32penkin merged commit 9028953 into next Feb 26, 2019
@artyorsh artyorsh deleted the feat/tooltip branch February 26, 2019 15:24
@artyorsh artyorsh self-assigned this Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➡️ Next Upcoming changes 📱 Components components module-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants