-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1 or 2 digits behind the decimal point #1292
Comments
Agreed, we should standardise and always show the decimal points. (2 of them) At the same time we should align the numbers to the right so that it becomes easier to evaluate the different values displayed. |
@KasperBrandt did we decide against adding decimals on the project listing page too, or should I do that now? |
@gabemart We haven't really decided on that. I tried it this morning and then realised that there's a limited space for numbers there.. But I think we should, in order to prevent the ".8" cases (see first image in this issue). So yeah, go ahead (same goes for the right alignment). |
I think the safest option for consistency is to always display them. (the decimals) |
There remains the question of how to align on narrower viewports - right alignment puts the currency amount very far from their labels. In my opinion makes things harder rather than easier to compare. Shall I only adjust the alignment on larger viewports for now? Another approach would be to narrow the width of the entire column of content, like so: |
@gabemart I think the second option looks good. I think we should fix it so that the amounts are shown on the same line as the labels as well. |
@KasperBrandt @loicsans is the use of a space between the currency symbol and the currency amount in some places but not others by design? When using align-right, sometimes line wrapping messes up the display There are different ways to approach this, but the easiest is just to never display a space between the currency symbol and the currency amount. Shall I take out the spaces? |
@gabemart Oh, I just put that in today because I thought it looked nicer. Maybe it's easier to remove the space again and keep it as is. |
Test planGIVEN the project finance page GIVEN the projects listing page |
See http://rsr.akvo.org/projects/?title=&location=&status=&organisation=§or=
Issue: one digit shown where one would expect 2 (.80):
Same on financial info page:
The text was updated successfully, but these errors were encountered: