Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 or 2 digits behind the decimal point #1292

Closed
mato74 opened this issue Mar 3, 2015 · 9 comments
Closed

1 or 2 digits behind the decimal point #1292

mato74 opened this issue Mar 3, 2015 · 9 comments
Assignees
Milestone

Comments

@mato74
Copy link

mato74 commented Mar 3, 2015

See http://rsr.akvo.org/projects/?title=&location=&status=&organisation=&sector=
Issue: one digit shown where one would expect 2 (.80):

screenshot 2015-03-03 15 49 57

Same on financial info page:
screenshot 2015-03-03 15 48 37

@adriancollier adriancollier added this to the 3.1 Episkopi milestone Mar 4, 2015
@adriancollier
Copy link
Contributor

Agreed, we should standardise and always show the decimal points. (2 of them)

At the same time we should align the numbers to the right so that it becomes easier to evaluate the different values displayed.

@gabemart
Copy link
Contributor

@KasperBrandt did we decide against adding decimals on the project listing page too, or should I do that now?

@KasperBrandt
Copy link
Contributor

@gabemart We haven't really decided on that. I tried it this morning and then realised that there's a limited space for numbers there.. But I think we should, in order to prevent the ".8" cases (see first image in this issue). So yeah, go ahead (same goes for the right alignment).

@adriancollier
Copy link
Contributor

I think the safest option for consistency is to always display them. (the decimals)

@gabemart
Copy link
Contributor

There remains the question of how to align on narrower viewports - right alignment puts the currency amount very far from their labels. In my opinion makes things harder rather than easier to compare. Shall I only adjust the alignment on larger viewports for now?

narrowviewport

Another approach would be to narrow the width of the entire column of content, like so:

financecolumn

@KasperBrandt
Copy link
Contributor

@gabemart I think the second option looks good. I think we should fix it so that the amounts are shown on the same line as the labels as well.

@gabemart
Copy link
Contributor

@KasperBrandt @loicsans is the use of a space between the currency symbol and the currency amount in some places but not others by design?

When using align-right, sometimes line wrapping messes up the display

foo

There are different ways to approach this, but the easiest is just to never display a space between the currency symbol and the currency amount. Shall I take out the spaces?

@KasperBrandt
Copy link
Contributor

@gabemart Oh, I just put that in today because I thought it looked nicer. Maybe it's easier to remove the space again and keep it as is.

loicsans added a commit that referenced this issue Mar 12, 2015
@KasperBrandt
Copy link
Contributor

Test plan

GIVEN the project finance page
WHEN an amount is shown
THEN it is aligned to the right
AND there's two digits behind the comma

GIVEN the projects listing page
WHEN the budget is shown
THEN it is aligned to the right
AND there's two digits behind the comma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants