Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign out, sign in caption in 403 page #150

Closed
relyd opened this issue Feb 25, 2013 · 7 comments
Closed

Sign out, sign in caption in 403 page #150

relyd opened this issue Feb 25, 2013 · 7 comments

Comments

@relyd
Copy link

relyd commented Feb 25, 2013

When logged in, and not having permissions to add project updates, you get a 403 and the sign-out button changes to 'sign in', even when already signed in.

@adriancollier
Copy link
Contributor

Part of this issue is not valid as the header does not currently show Signed In Status, But we do still need to provide a better Message for when trying to Add Updates to a project that you don't have the right permissions to update.

@KasperBrandt
Copy link
Contributor

@adriancollier The sign in/out thing is changed, but what should we update on the page itself? The current "You don't have permission to add updates to this project." seems clear to me.

Something else that I was thinking of is to remove the update button from the project page when someone is not allowed to update. Or is there a reason why that hasn't been done already?

@adriancollier
Copy link
Contributor

Might be worth getting the opinion of @loicsans but what about a greyed out Update button for this?

@adriancollier
Copy link
Contributor

Shall we try out a greyed out update button and then see how that looks to be reviewed?

@KasperBrandt
Copy link
Contributor

yep, will do..

@kardan
Copy link
Contributor

kardan commented Apr 24, 2014

👍

kardan added a commit that referenced this issue Apr 24, 2014
[#150] Added user profile to 403 page and greyed out update button for projects
@KasperBrandt
Copy link
Contributor

Test plan

  1. 403 page
    GIVEN a 403 page on core RSR
    WHEN a user is logged in
    THEN it is still shown in the header of the 403 page that the user is logged in
  2. Not signed in
    GIVEN any page with an update button on core RSR
    WHEN a user is not logged in
    THEN the update button is greyed out
    AND a text is shown stating that the user has to log in to post an update
  3. No permission
    GIVEN any page with an update button on core RSR
    WHEN a user is logged in
    AND the user has no permission to post an update for a project
    THEN the update button is greyed out
    AND a text is shown stating that the user has no permission to post updates for that project

@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants