-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show clear 403 message #1571
Comments
zzgvh
added a commit
that referenced
this issue
Aug 4, 2015
It's not possible to create project updates to projects that aren't published. Remove the link to the update form in MyRSR's project list and only link to the form on project pages of published projects.
@gabemart I'm assigning this to you for a final UI touch. These lines should be replaced with something like this: {% if project.is_published %}
{% has_perm 'rsr.post_updates' project as can_add_update %}
<a href="{% url 'add-update' project.pk %}">{% trans 'Update' %}</a>
{% else %}
<!-- a greyed out button without a link -->
{% endif %} This way we get a consistent look rather than the current cludge: Problem is I don't have a clue how to create such a disabled button... |
gabemart
added a commit
that referenced
this issue
Aug 7, 2015
@zzgvh @KasperBrandt Here is my interpretation of a disabled button |
Looks good to me! @KasperBrandt ? |
KasperBrandt
added a commit
that referenced
this issue
Aug 14, 2015
KasperBrandt
added a commit
that referenced
this issue
Aug 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test plan
GIVEN the My Projects page
WHEN a project is unpublished
THEN the 'Update' button should be disabled
WHEN the user is on the page
THEN the 'Add an update' button in the top navigation should not be displayed
WHEN a project's location doesn't have a country
THEN there should be a placeholder stating 'Location unknown'
WHEN a project doesn't have a title
THEN there should be a placeholder stating 'Untitled project'
Issue description
When a user is logged in and goes to the "Add Update" page to update a non-published project, a simple 403 message (forbidden) is displayed.
To make it more clear that they can't post an update (or view the project) because the project is not published, we should provide a more user friendly forbidden message.
The text was updated successfully, but these errors were encountered: