Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI issue with translations header on small windows #1596

Closed
rumca opened this issue Jun 3, 2015 · 5 comments · Fixed by #1599
Closed

Minor UI issue with translations header on small windows #1596

rumca opened this issue Jun 3, 2015 · 5 comments · Fixed by #1599

Comments

@rumca
Copy link
Contributor

rumca commented Jun 3, 2015

@gabemart @loicsans not sure who to assign this to, or if it's worth addressing?

Due to the fact the button labels are slightly longer when they are in French or Spanish, the following happens with a smaller browser window:

screen shot 2015-06-03 at 10 24 02

If you resize to whatever is presumably the max width for the english labels then you get the expected collapse behaviour:

screen shot 2015-06-03 at 10 25 20

Also with the collapsed menu, when you click to swap the translation it looks a little wacky:

screen shot 2015-06-03 at 10 32 14

@rumca rumca added this to the 3.4 Honiara milestone Jun 3, 2015
@gabemart gabemart self-assigned this Jun 3, 2015
@gabemart
Copy link
Contributor

gabemart commented Jun 3, 2015

@rumca I'm having trouble reproducing the first problem - on my machine the collapse behaviour is correct even when using spanish or french labels. What browser width triggers the improper behaviour for you?

Agreed on the second point, behaviour is not as expected

@KasperBrandt
Copy link
Contributor

@rumca @gabemart Same for me, collapsing behaviour of the header seems fine with French and Spanish.

Although I do notice that the language selector is acting strangely when the navigation is folded:

screen shot 2015-06-03 at 12 34 18

@gabemart
Copy link
Contributor

gabemart commented Jun 3, 2015

I've fixed the language dropdown issue, but it involves changing the vertical overflow on the nav container to initial. As far as I know this doesn't have any side effects as the nav menu has a fixed amount of content, but I'm not sure

rsr-lang

@rumca
Copy link
Contributor Author

rumca commented Jun 3, 2015

@gabemart with the first issue I'm using Chrome (v43) and widths from 1025-1200px with Spanish translations result in the header appearing like that.

@gabemart
Copy link
Contributor

gabemart commented Jun 3, 2015

@rumca ha, I was testing when logged in, which doesn't trigger the overflow, because "Desconexion" is shorter than "Inicio de sesion"

should be a straightforward fix, either by bumping the width of the container or reducing the width of the logo

Edit: bumped the container width

loicsans added a commit that referenced this issue Jun 3, 2015
[#1596] fix language dropdown on narrow viewports
loicsans added a commit that referenced this issue Jun 3, 2015
[#1596] keep nav menu on one line in ES and FR
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants