Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate feature Akvo Pages #1617

Closed
lauraroverts opened this issue Jun 11, 2015 · 5 comments
Closed

Translate feature Akvo Pages #1617

lauraroverts opened this issue Jun 11, 2015 · 5 comments
Assignees
@kardan
Labels
Type: Translations
Milestone
3.4 Honiara

Comments

@lauraroverts
Copy link

See akvo/akvo-product-design#106

To clarify:

  • Only for Akvo Pages
  • Not sure where to put this yet

Test plan

  1. A setting on Akvo Pages (/partnersites/ in the admin) for Google Translate function
  2. If selected, the Google Translate widget should display on the Akvo Page
  3. If not, the Akvo Translate selector should be displayed
  4. If the Google Translate widget is selected, the page should have spacing on top for showing the Google Translate widget
  5. The whole page should be translated when a language is selected in the Google Translate widget
@lauraroverts lauraroverts added this to the 3.4 Honiara milestone Jun 11, 2015
@kardan
Copy link
Contributor

kardan commented Jun 12, 2015

@loicsans we will need UX/UI work on how to deal with two sets of language pickers.

@kardan kardan assigned loicsans and kardan and unassigned loicsans Jun 12, 2015
@kardan kardan added In Progress and removed Ready labels Jun 16, 2015
kardan added a commit that referenced this issue Jun 22, 2015
@kardan
[#1617] Enabled Google translation bar option on pages
ede0ac9 
The translation bar can now be enabled per RSR page basis. This includes a
crude CSS tweak to make the translation bar and the RSR navbar happy. Could
not find a way to support default langauges so this option is disabled in
the admin.

Since we want to implement default lanaguage option traces is left in the
defaultLocaleMiddleware, but it's broken at the moment. This since it's
difficult to know if a path is an i18n one or not.
kardan added a commit that referenced this issue Jun 22, 2015
@kardan
Merge branch 'develop' into #1617-google-translate
28b3c54
@kardan
Copy link
Contributor

kardan commented Jun 22, 2015

Test plan:

With the minimal test dataset & the following entry to /etc/hosts (local host computer)
192.168.50.101 gooddeeds.localakvoapp.org

The Good deeds RSR page should be visible at gooddeeds.localakvoapp.org

If one enable the Google translate bar in the admin and then RSR should display a Google dropdown top right.

gabemart added a commit that referenced this issue Jun 22, 2015
@gabemart
[#1617] move template styles to main.scss
42e0df3
kardan added a commit that referenced this issue Jun 22, 2015
@kardan
Merge pull request #1623 from akvo/#1617-google-translate
7a4156a 
#1617 google translate
@kardan kardan closed this as completed Jun 22, 2015
@KasperBrandt
Copy link
Contributor

There are some styling issues, which @gabemart is looking into.

@KasperBrandt KasperBrandt reopened this Jun 23, 2015
@KasperBrandt KasperBrandt mentioned this issue Jun 23, 2015
Closed
gabemart added a commit that referenced this issue Jun 23, 2015
@gabemart
[#1617] adjust article spacing for translation bar
31ea918
@gabemart gabemart mentioned this issue Jun 23, 2015
Merged
KasperBrandt added a commit that referenced this issue Jun 23, 2015
@KasperBrandt
[#1617] Don't show Akvo and Google translations together
03d4d16
gabemart added a commit that referenced this issue Jun 23, 2015
@gabemart
[#1617] adjust update, org and map spacing
4d5dda2
KasperBrandt added a commit that referenced this issue Jun 23, 2015
@KasperBrandt
Merge pull request #1626 from akvo/#1617-google-translate
e9b33f2 
[#1617] google translate CSS tweaks
kardan added a commit that referenced this issue Jun 23, 2015
@kardan
[#1617] Made lanague selectors a binary option.
4596509
kardan added a commit that referenced this issue Jun 23, 2015
@kardan
[#1617] Merge with new changes
c7ef4d7
@rumca
Copy link
Contributor

rumca commented Jun 24, 2015

@gabemart this might be the intended styling, but just double checking. With our own translation drop down the header looks like:

screen shot 2015-06-24 at 10 00 47

However when I enable the google widget the top padding seems to ramp up quite a bit:

screen shot 2015-06-24 at 10 01 09

@KasperBrandt
Copy link
Contributor

@rumca Yup, that's intended. When you select a language in the Google Translate widget, it inserts a row above the page that we cannot control. Other than the current solution, we can't do much about it I'm afraid..

@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kardan kardan

Labels
Type: Translations
Projects
RSR
Archived in project
Milestone
3.4 Honiara
Development

No branches or pull requests
5 participants
@kardan @KasperBrandt @loicsans @rumca @lauraroverts