Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partnerships with no organisations should not be allowed #1750

Closed
KasperBrandt opened this issue Aug 19, 2015 · 1 comment
Closed

Partnerships with no organisations should not be allowed #1750

KasperBrandt opened this issue Aug 19, 2015 · 1 comment
Assignees
@KasperBrandt
Labels
Bug Type: Project editor
Milestone
3.6 Jakarta

Comments

@KasperBrandt
Copy link
Contributor

Test plan

GIVEN the project editor
WHEN the project has a funding partnership without an organisation
THEN an error should be displayed that the organisation field isn't filled in
@KasperBrandt KasperBrandt self-assigned this Aug 19, 2015
@KasperBrandt KasperBrandt added this to the 3.6 Jakarta milestone Aug 19, 2015
KasperBrandt added a commit that referenced this issue Aug 20, 2015
@KasperBrandt
[#1750] Fix project funding template
2480ab1
@KasperBrandt KasperBrandt mentioned this issue Aug 20, 2015
Merged
@zzgvh
Copy link
Contributor

zzgvh commented Aug 24, 2015

Actually I think I disagree with the solution here. Is there any scenario where it's valid to have a funding amount without a funding organisation? If not then there should be validation preventing this data from being entered.

@zzgvh zzgvh mentioned this issue Aug 24, 2015
Merged
KasperBrandt added a commit that referenced this issue Aug 25, 2015
@KasperBrandt
[#1750] Merge branch '#1633_partner_types_and_iati_roles' into #1750-…
15a7bd5 
…finance-no-org

In order to get all migrations, the #1633_partner_types_and_iati_roles needs to be merged in.
KasperBrandt added a commit that referenced this issue Aug 25, 2015
@KasperBrandt
[Fixes #1750] Organisation mandatory in Partnership model
feec514
@KasperBrandt KasperBrandt changed the title Partnerships with no organisation on finance page Partnerships with no organisations should not be allowed Aug 25, 2015
KasperBrandt added a commit that referenced this issue Aug 26, 2015
@KasperBrandt
[#1750] Added custom validation for mandatory partnership.organisation
1843d52
KasperBrandt added a commit that referenced this issue Aug 26, 2015
@KasperBrandt
[#1750] Fix finance page template
3fdbcb9
KasperBrandt added a commit that referenced this issue Aug 26, 2015
@KasperBrandt
Merge pull request #1755 from akvo/#1750-finance-no-org
ca02838 
[Fixes #1750] Fix project funding template
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KasperBrandt KasperBrandt

Labels
Bug Type: Project editor
Projects
RSR
Archived in project
Milestone
3.6 Jakarta
Development

No branches or pull requests
2 participants
@zzgvh @KasperBrandt