Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Zepto (and jQuery) from project editor #1765

Closed
KasperBrandt opened this issue Aug 25, 2015 · 2 comments
Closed

Remove Zepto (and jQuery) from project editor #1765

KasperBrandt opened this issue Aug 25, 2015 · 2 comments

Comments

@KasperBrandt
Copy link
Contributor

As a first step to completely remove jQuery from RSR, let's remove it completely from the project editor. As far as I know we only use Zepto, but that should also be rewritten to regular Javascript.

@gabemart
Copy link
Contributor

Test Plan

The test procedure should ensure the functionality of the project editor does not change when merging in this branch.

  1. Enter the project editor with an active project

  2. Verify that adding new subsections works properly. E.g. "Related project" in section 1.

  3. Verify that clicking on the small info icons (i) toggles the appearance of the appropriate help text for the particular icon. Verify this behaviour is also correct in newly added subsections.

  4. Verify the autocomplete feature works for the appropriate inputs - E.g. "Related project" in section 1. Verify this behaviour is also correct in newly added subsections.

  5. Verify the datepicker works for date inputs, including date inputs in newly added subsections - e.g. "Indicator period" in section 5.

  6. Verify character limits work for appropriate inputs, including in newly added subsections - e.g. "Target Value" in section 5

  7. Verify the image upload facility operates correctly in section 1

  8. Verify that removing subsections using the red trashcan icon works correctly

  9. Verify that the "save" functionality works correctly, including correclty storing the removal or addition of subsections

KasperBrandt added a commit that referenced this issue Sep 14, 2015
[#1765] remove zepto dependency from project editor
@gabemart gabemart reopened this Sep 16, 2015
@lauraroverts lauraroverts modified the milestones: 3.7 Khartoum, Priority 1 Sep 16, 2015
@KasperBrandt KasperBrandt modified the milestones: Priority 1, 3.7 Khartoum Sep 17, 2015
KasperBrandt added a commit that referenced this issue Sep 17, 2015
[#1765] test for classList.forEach before using
@KasperBrandt
Copy link
Contributor Author

Fixed in #1805

@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants