Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amusing UI issue - save button evades clicking #1791

Closed
rumca opened this issue Sep 2, 2015 · 2 comments
Closed

Amusing UI issue - save button evades clicking #1791

rumca opened this issue Sep 2, 2015 · 2 comments
Assignees
Milestone

Comments

@rumca
Copy link
Contributor

rumca commented Sep 2, 2015

When filling out a field which has a character limit (e.g. Photo caption or Photo credit) when a user goes to click the save button - the on focus loss event or which event is responsible for removing the character count fires before the onclick even on the button:

screen shot 2015-09-02 at 14 03 51

screen shot 2015-09-02 at 14 03 59

This means that from the user's perspective they seem to be clicking the button twice before it actually saves.

@gabemart
Copy link
Contributor

gabemart commented Sep 2, 2015

I can reproduce and can confirm, it's amusing.

Should be a simple fix using a setTimeout for the listener. I'll make the change once I'm done rewriting the zepto stuff in vanilla js.

@gabemart
Copy link
Contributor

Test Plan

  1. In the Project Editor, select the "Photo caption" input and add some characters

  2. Verify the "characters left" help text appears"

  3. Click the "Save" button.

  4. Verify the save button is activated on the first click

  5. Verify the "characters left" help text disappears shortly after the first click

@lauraroverts lauraroverts modified the milestones: 3.7 Khartoum, Priority 1 Sep 16, 2015
@KasperBrandt KasperBrandt modified the milestones: Priority 1, 3.7 Khartoum Sep 17, 2015
KasperBrandt added a commit that referenced this issue Sep 17, 2015
[#1791] use setTimeout so save clicks propagate
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants