Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta Tagging in RSR for Sharing #196

Closed
adriancollier opened this issue Apr 25, 2013 · 22 comments
Closed

Meta Tagging in RSR for Sharing #196

adriancollier opened this issue Apr 25, 2013 · 22 comments
Assignees
Milestone

Comments

@adriancollier
Copy link
Contributor

Meta Tags in RSR Need to be updated.

A full description of the changes required are described in this document:

https://www.dropbox.com/s/8pwdsm1huogvgm4/Meta-Tags%20-%20Version%202.pdf

@adriancollier
Copy link
Contributor Author

<html xmlns="http://www.w3.org/1999/xhtml"
      xmlns:og="http://ogp.me/ns#"
      xmlns:fb="https://www.facebook.com/2008/fbml">
  <head>
    <title>The Rock (1996)</title>
    <meta property="og:title" content="The Rock"/>
    <meta property="og:type" content="movie"/>
    <meta property="og:url" content="http://www.imdb.com/title/tt0117500/"/>
    <meta property="og:image" content="http://ia.media-imdb.com/rock.jpg"/>
    <meta property="fb:admins" content="USER_ID"/>
    <meta property="og:description"
          content="A group of U.S. Marines, under command of
                   a renegade general, take over Alcatraz and
                   threaten San Francisco Bay with biological
                   weapons."/>
    ...
  </head>
  ...
</html> 

@ghost ghost assigned stellanl Aug 8, 2013
@adriancollier
Copy link
Contributor Author

When there is no image attached to the item you are sharing, the Akvo logo is displayed, but this is zoomed too much so you can't see it:
screen shot 2013-09-03 at 17 04 53

@stellanl
Copy link
Contributor

stellanl commented Sep 6, 2013

Ok, that akvo logo is 200px wide by 75. I assume a square one would work better.
Making one.

@peeb
Copy link
Contributor

peeb commented Sep 24, 2013

Code reviewed and complete.

@adriancollier
Copy link
Contributor Author

Still problems with default Akvo logo:
screen shot 2013-09-24 at 15 24 00

UPDATED IMAGE

@carlio
Copy link
Contributor

carlio commented Sep 24, 2013

One solution: the facebook image finder uses a distinctive user agent (or did 3 years ago...) so perhaps for a hit on the project update page from that UA we should serve a summary designed for FB

@stellanl
Copy link
Contributor

The meta-tag for image is set to the project image, but that is still not the only or even the first of the choosable thumbnails. If an organisation has no image the image hint is pointed to a square version of our logo.
I wonder if there is a way to tell the FB parser to NOT use a particular image on the page...

@adriancollier
Copy link
Contributor Author

The above example was the first image that was provided by FB.

I know you swapped it with a square, but wondering if we actually need a smaller thumbnail sized image for this sharing?

@adriancollier
Copy link
Contributor Author

FYI the Organisation one looks great, so maybe ignore my last comment and see if we can do the same thing for projects 😄
screen shot 2013-09-25 at 9 37 40

@stellanl
Copy link
Contributor

Ok, found and applied FB's diagnosis tool: https://developers.facebook.com/tools/debug/
Apparently they disregard any tag-provided image smaller than 200x200px.

@stellanl
Copy link
Contributor

Seems to work at the user end.

@ghost ghost assigned adriancollier Oct 1, 2013
@adriancollier
Copy link
Contributor Author

Problem with Image for Earth Water (and other orgs even with photo): http://akvo.akvotest.org/en/organisation/52/

screen shot 2013-10-01 at 14 58 22

@stellanl
Copy link
Contributor

stellanl commented Oct 1, 2013

Reproduced this. I get no og: meta-tags at all here. Maybe I have overwritten something in a template...

@rumca
Copy link
Contributor

rumca commented Oct 7, 2013

Still seeing an issue where the logo is too large/zoomed in to make out:

largeicon

largeicon2

@osg74
Copy link

osg74 commented Oct 7, 2013

Moved to release 2.3.1 as fixes were still needed.

@ghost ghost assigned stellanl Oct 7, 2013
@osg74
Copy link

osg74 commented Oct 7, 2013

@stellanl Could you add some deployment notes if necessary for this feature please.

@stellanl
Copy link
Contributor

The remaining issue is when a logo image is long and narrow. FB will generate a square thumbnail by zooming in on the middle of it. Only solution seems to be to generate a special FB-friendly thumbnail, by centering image on a square white background.

@adriancollier
Copy link
Contributor Author

So do we need to make changes to the Thumbnail generation when you upload an image to RSR?

And if so, can we also run this on the existing images to create those?

Or is there an alternative solution?

@stellanl
Copy link
Contributor

No, it should be easy to use what we have. Just need to zoom out and not in when generating a square thumbnail. And AFAIK, we can have several thumbnails associated w the same image.

@adriancollier
Copy link
Contributor Author

@stellanl - is this potentially ready enough to be included in the 2.3.1 release? If so, can you get this code-checked please?

If not, can you please outline what is left (and how much time this might take)?

@adriancollier
Copy link
Contributor Author

Reviewed

@rumca
Copy link
Contributor

rumca commented Oct 31, 2013

Zoomed image thumbnails are still occurring with this.

I've re-opened the issue for now, but we could perhaps create a new issue for a future release to sort out the thumbnails if we want to release what we've got so far?

@rumca rumca reopened this Oct 31, 2013
@osg74 osg74 closed this as completed Nov 7, 2013
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

6 participants