Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requesting a non existing widget causes a 500 and not a 404 #198

Closed
kardan opened this issue May 7, 2013 · 2 comments
Closed

Requesting a non existing widget causes a 500 and not a 404 #198

kardan opened this issue May 7, 2013 · 2 comments
Assignees
@KasperBrandt
Labels
Bug Type: Widgets
Milestone
2.3.10 Zambo

Comments

@kardan
Copy link
Contributor

kardan commented May 7, 2013

Example:
http://akvo.org/rsr/widget/project-narrow/project/636/
http://akvo.org/rsr/widget/nonexistingtemplate/project/636/
&
http://akvo.org/rsr/widget/one-from-organisation/305/?widget=project-narrow
http://akvo.org/rsr/widget/one-from-organisation/305/?widget=nonexistingtemplate

The reason for this is that we blindly apply the user provided data to grab the correct template.

I would suggest that we remove the magic and try to be explicit in what widget we handle (manual urls & views).
@adriancollier adriancollier modified the milestones: 2.3.10 Zambo, 2.4 Astana Jul 1, 2014
@KasperBrandt KasperBrandt self-assigned this Jul 2, 2014
KasperBrandt added a commit that referenced this issue Jul 3, 2014
@KasperBrandt
[#198] Added allowed widget templates list
d91f493
KasperBrandt added a commit that referenced this issue Jul 3, 2014
@KasperBrandt
[#198] Raise 404 when widget not found
3144c39
zzgvh added a commit that referenced this issue Jul 3, 2014
@zzgvh
Merge pull request #669 from akvo/feature/198_nonwidget_forbidden
085ea22 
[#198] Added allowed widget templates list
@KasperBrandt
Copy link
Contributor

Merged in #669

@KasperBrandt
Copy link
Contributor

Test plan

GIVEN a non-existing widget
WHEN the widget is accessed
THEN the 404 page should be shown

@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KasperBrandt KasperBrandt

Labels
Bug Type: Widgets
Projects
RSR
Archived in project
Milestone
2.3.10 Zambo
Development

No branches or pull requests
4 participants
@kardan @adriancollier @KasperBrandt @rumca