Ongoing improvements data entry in My Results

[lauraroverts]

Test plan

GIVEN the top navigation of RSR
WHEN viewing the available menu items
THEN there should be no 'Add update' button

GIVEN the results framework
WHEN a result is selected
THEN the first indicator should automatically be selected
OR a message should state that there are no indicators yet (in case of 0 indicators)

GIVEN the results framework in MyRSR
WHEN performing an action (un/lock period, add new update, save update, submit for approval, approve)
THEN a loading icon should be shown

GIVEN the results framework in MyRSR
WHEN an indicator period with updates has been opened
THEN the color of the update's status should change based on the status

Issue description

Feedback was provided to the results framework. Comments can be found in https://docs.google.com/document/d/1ItBXFwT4pmkxWQTGx0QSPbIdy5IQc2K6CYiCP6EcQ_0/edit

• Confusing to have an 'Add an update' button for Narrative RSR updates and ‘+ New indicator update’ to enter new results data. And there is an 'Updates' and 'My updates' tab. Needs to be clear what the different updates can do and think about which button to show at which page.

• When there is just one indicator; is it possible to see it immediately when you click on the result?
  
• Rename 'Periods' to 'Period(s): e.g. sometimes there is only one indicator period.
• When I click ‘indicator update’ I want to immeditately update my indicator, instead of having to click on ‘+ new indicator update’ first
  
  
• After clicking ‘submit for approval’ it takes several seconds for the next screen to load. Show a loader to make clear that it's loading and people don’t press twice.
• Clicking indicator period dates is not intuitive. Propose to remove the link there and add a ‘View’ action on the right (won't fix)
  
• Suggest to change the colour of Approved from red to green once data is approved.
• Alignment of target values, actual values is different when a period is locked/unlocked

• Confusing by adding a comment you don't need to press 'add comment' but to add an internal comment you have to click 'add comment'. It's not clear to everyone and therefore it looks like sometimes the internal updates get lost.

• If you click Return for revision, you can immediately add an internal comment, but to edit the actual value, you first have to click 'edit update'.

• Show result type. You can indicate this in the project editor, but it's not visible in My Results.