Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change analytics URL to use https protocol #2013

Closed
iperdomo opened this issue Feb 24, 2016 · 2 comments
Closed

Change analytics URL to use https protocol #2013

iperdomo opened this issue Feb 24, 2016 · 2 comments
Assignees
@KasperBrandt
Labels
Quick Fix
Milestone
3.11.2 Ouagadougo...

Comments

@iperdomo
Copy link
Contributor

The current piwik analytics code use a hardcoded http:// protocol for including the js file.

https://github.com/akvo/akvo-rsr/blob/v3.10/akvo/templates/piwik/tracking_code.html#L5

The analytics server supports https:// and we should use it to avoid an extra (301) http request.
@KasperBrandt KasperBrandt changed the title Chage analytics URL to use https protocol Change analytics URL to use https protocol Feb 24, 2016
@KasperBrandt
Copy link
Contributor

@iperdomo Changing http:// to // should be enough, right?

KasperBrandt added a commit that referenced this issue Feb 24, 2016
@KasperBrandt
[#2013] Update Piwik to correct URL
b3f10ce
KasperBrandt added a commit that referenced this issue Feb 24, 2016
@KasperBrandt
Merge pull request #2019 from akvo/#2018-js-load-error
3e03220 
[Fixes #2013 #2018] Change Piwik URL, and remove ReactBootstrap partly
@iperdomo
Copy link
Contributor Author

@KasperBrandt I would encourage use a fixed https:// instead of a relative protocol.

Not sure if the change you introduced in the PIWIK_URL breaks the template as we append the /piwik.js dynamically.

https://github.com/akvo/akvo-rsr/blob/v3.10/akvo/templates/piwik/tracking_code.html#L6

@KasperBrandt KasperBrandt reopened this Feb 25, 2016
KasperBrandt added a commit that referenced this issue Feb 25, 2016
@KasperBrandt
[#2013] Set Piwik URL to https by default
d63918c
@KasperBrandt KasperBrandt mentioned this issue Feb 25, 2016
Merged
iperdomo added a commit that referenced this issue Feb 25, 2016
@iperdomo
Merge pull request #2021 from akvo/#2013-https-piwik
6676de7 
[#2013] Set Piwik URL to https by default
zzgvh added a commit that referenced this issue Dec 6, 2017
@zzgvh
[#2013] Att tabs to main results view
8f85079 
Add two tabs, one for results and one for narrative reports.

Also add fetching of narrative reports and categories (actually organisation indicator labels)
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KasperBrandt KasperBrandt

Labels
Quick Fix
Projects
RSR
Archived in project
Milestone
3.11.2 Ouagadougou (Hotfix 2)
Development

No branches or pull requests
3 participants
@kardan @iperdomo @KasperBrandt