List partner as support partner

[lauraroverts]

• In admin everybody with editor rights can list any partner as a support partner. This should not be possible. Only Akvo staff can list partners as a support partner.
• Thomas said is important.

[adriancollier]

OK, understood as a requirement but this has a few implications:

1. What about partners such as UNDP who are managing all of their own projects?
2. What happens if a support partner wants to add a project? (The project cannot be created as the Support Partner would not be able to be added)
3. We create an additional manual step for every project being created that Akvo must complete - do we have the capacity (and agreement) to support this?

[lauraroverts]

As we talked about briefly yesterday, it should be like this:
In the admin 'organisations' there must be check boxes where you can check if a partner is a field/support/sponsor/funding partner.
So if a partner is checked a support partner only this list of partners can be chosen from as a support partner in the admin 'projects'. This implicates that Akvo staff decides who is a support partner and who not, so people with editor or admin rights can only choose from these partners.

[zzgvh]

I see two solutions, one simple and klunky, one complex and cool.

The simple and "Djangoish" way of solving this is to write a validator that checks if an organisation can be a partner of the selected type when the form is submitted. If not, the form is returned to the user with an error message that lists the allowed choices of partner type.

To make a cool solution for this is non-trivial. The reason is that the selection of partner types is dynamically dependent on the choice of organisation. This is not supported by the Django admin. This is not the first time someone has a problem like this however, so there's code to be used as the basis for this like https://bitbucket.org/mlavin/django-selectable which seems to be actively maintained. It uses jqueryui to do its magic.

We have other reasons for working on this problem too. The organisation list is already waaaaaay too long and really needs an auto-complete feature. Another area where this would be very cool is in the project listing where you'd want to change the possible choices for country and continent when an organisation is selected in the filter (and the other way around too, limit the org list to the relevant ones for a country or continent).

[lauraroverts]

hi @zzgvh. could we shortly skype about this? Would be easier to make clear what kind of sulution the partner team is looking for. I also agree with you the organisation list is too long.

[zzgvh]

Deployed to UAT

[adriancollier]

@peeb can you please code check this?
@lauraroverts could you please check out http://uat.akvo.org and see if this is working the way you need it to?

[lauraroverts]

If I click on any organisation in http://uat.akvo.org admin, we can select if a partner is support/sponsor/funding/field partner. This is what we want. Great!

[adriancollier]

Can you also check the negative fo this:

If a partner is not already tagged as a Field/Fudning/Sponsor/Support that they should not be selectable as this?

[zzgvh]

Unfortunately they are selectable as all kinds of partners, but the validation only lets you save if you've chosen valid ones. Otherwise you'll get an error message when saving telling you what the problem is.

As mentioned above this can't be solved in a nicer way without some AJAX magic that populates the Partner type field when you select an organisation. Doable but outside the scope of the regular Django admin's capabilities.

[adriancollier]

Works for me - all functionality is as expected.