Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show error message if image file is too big when placing update (estimate: 6) #2040

Closed
KasperBrandt opened this issue Mar 7, 2016 · 2 comments
Closed

Show error message if image file is too big when placing update (estimate: 6) #2040

KasperBrandt opened this issue Mar 7, 2016 · 2 comments
Assignees
@punchagan
Labels
Bug
Milestone
3.17 Ulaanbaatar

Comments

@KasperBrandt
Copy link
Contributor

Currently, placing an update fails silently when the image attached is too big. We should add a nice error message for that.
@KasperBrandt KasperBrandt self-assigned this Mar 7, 2016
@nadiagorchakova nadiagorchakova changed the title Show error message if image file is too big when placing update Show error message if image file is too big when placing update (estimate: 6) Sep 29, 2016
@nadiagorchakova nadiagorchakova added this to the 3.17 Ulaanbaatar milestone Sep 29, 2016
@punchagan
Copy link
Contributor

@nadiagorchakova Can you remind me if this issue is for the RSR website or for Up app?

If this is for the web-site, this discussion seems relevant. But, the limit for the web-site has been made way higher, so this is no longer an issue.

We could add a front-end check, but I think this is not all that important anymore. Thoughts? /cc @zzgvh

@nadiagorchakova
Copy link
Contributor

@punchagan The issue is for RSR website.

Right now RSR can handle images less than 3.5mb in size. However, as far as I know, partners with poor internet connection in project countries still face the issue. It takes too much time to load and the update page probably times out.
I also see that in here #219 Kasper wrote some code to add help text on max image size. I don't see it implemented in RSR though. Would be helpful to have it implemented, in addition to the post-factum error message.

punchagan added a commit that referenced this issue Oct 6, 2016
@punchagan
[#2040] Add a js check for image upload size
6a168e1 
Also add help text recommending images smaller than 2MB
@punchagan punchagan self-assigned this Oct 6, 2016
@punchagan punchagan mentioned this issue Oct 6, 2016
Merged
punchagan added a commit that referenced this issue Oct 7, 2016
@punchagan
[#2040] Add a js check for image upload size
18fca68 
- Also, add help text recommending images smaller than 2MB

- Disable submit if a large file has been selected, until it is removed
  or replaced with a smaller file.
zzgvh added a commit that referenced this issue Oct 7, 2016
@zzgvh
Merge pull request #2394 from akvo/#2040-image-upload-size
806930a 
[#2040] Add a js check for image upload size.

Great!
@zzgvh zzgvh removed the Needs Review label Oct 7, 2016
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punchagan punchagan

Labels
Bug
Projects
RSR
Archived in project
Milestone
3.17 Ulaanbaatar
Development

No branches or pull requests
4 participants
@zzgvh @punchagan @KasperBrandt @nadiagorchakova