API returns duplicate project updates

[osg74]

The RSR API call to retrieve project updates returns two of each update, e.g.

http://www.akvo.org/api/v1/project_update/?format=json&project__partnerships__organisation=912

[zzgvh]

This can be resolved by adding distinct=True to the query string. The call above would then look like this:

http://www.akvo.org/api/v1/project_update/?format=json&project__partnerships__organisation=912&distinct=True

Oli commented online that distinct=True should be the default behavior and that sounds like a good idea.

[zzgvh]

Duplicates should probably still happen when using the depth param since you will get different associated data for the duplicates of the "main" objects.

[osg74]

Perhaps rather use the logic behind the depth param to determine when to return duplicates and otherwise return distinct results as discussed above.

[adriancollier]

@zzgvh Is there a change needed in our API or should we just advise all our partners and modify our documentation to mentioned that distinct should be used on live API calls?

[adriancollier]

@zzgvh your thoughts on this? Just wondering if we need to plan change for coding or for documentation/advice?

[zzgvh]

Coding done, but I'm not "publishing" it before we have a pull request workflow in place.

[zzgvh]

The fix was so small it felt like overkill to make a branch and pull request.

[adriancollier]

Reviewed