Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled project edits, results and updates are still accessable in myRSR through URL manipulation #2149

Closed
damienallen opened this issue May 9, 2016 · 1 comment

Comments

@damienallen
Copy link
Contributor

damienallen commented May 9, 2016

Buttons for edits, results and updates in myRSR/My Projects are sometimes disabled for projects depending on their status (eg. unpublished or complete). However, these pages can still be accessed directly by URL. Thus, access to the following pages should be restricted (raise 403 forbidden) accordingly under the same circumstances:

http://rsr.localdev.akvo.org/en/myrsr/project_editor/5/
http://rsr.localdev.akvo.org/en/myrsr/results/5/
http://rsr.localdev.akvo.org/en/project/5/add_update/

To clarify, the project id (in bold) can be changed to access project pages which should be disabled. Note, exceptions should be made for superuser where appropriate.

@damienallen
Copy link
Contributor Author

damienallen commented May 23, 2016

Test plan

Try opening projects with 'completed' status, 'unpublished' status and with neither.

  • Completed: project editor, results and add update should raise 403
  • Unpublished: only results and add update should raise 403
  • Otherwise: no error should be raised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants