Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sector codes in project editor #2223

Closed
3 tasks done
KasperBrandt opened this issue Jun 6, 2016 · 1 comment
Closed
3 tasks done

Sector codes in project editor #2223

KasperBrandt opened this issue Jun 6, 2016 · 1 comment
Assignees
@damienallen
Labels
Type: Project editor
Milestone
3.15 Suva

Comments

@KasperBrandt
Copy link
Contributor

KasperBrandt commented Jun 6, 2016 •
edited by damienallen
Loading

  • Remove permanent help text for sectors.
  • Select DAC-3 and DAC-5 from lists.
  • Remove sector mandatory for RSR validation set. Also in publishing status checks.
@KasperBrandt KasperBrandt added this to the 3.15 Suva milestone Jun 6, 2016
damienallen added a commit that referenced this issue Jun 20, 2016
@damienallen
[Fixes #2223] Removed permanent help text
240042f
damienallen added a commit that referenced this issue Jun 20, 2016
@damienallen
[Fixes #2223] Added migration to modify ProjectEditorValidation entries
73303d7
damienallen added a commit that referenced this issue Jun 21, 2016
@damienallen
[Fixes #2223] Add hidden fields with IATI sector codelists
f3f1b72
damienallen added a commit that referenced this issue Jun 21, 2016
@damienallen
[Fixes #2223] JS added for field switching
d5cfcc1
damienallen added a commit that referenced this issue Jun 22, 2016
@damienallen
[Fixes #2223] Finalized JS and ironed out bugs
0b88541
@damienallen
Copy link
Contributor

damienallen commented Jun 22, 2016 •
edited by KasperBrandt
Loading

Test plan

  • Sector should no longer be a required field in RSR (must run migration first)
  • Permanent help text should no longer be present
  • In 'Project Focus - Sectors', sector codes for DAC-3 and DAC-5 vocabularies should be selectable by dropdown and otherwise by text input.
  • Section should still function when sector vocabularies/codes are changed with/without saving, and also if new sectors are added.
  • It should be possible to publish an RSR project (non-IATI and non-DGIS) without any sectors.

@damienallen damienallen mentioned this issue Jun 22, 2016
Merged
damienallen added a commit that referenced this issue Jun 22, 2016
@damienallen
[Fixes #2223] Updated migration dependency
c93d761
damienallen added a commit that referenced this issue Jun 27, 2016
@damienallen
[Fixes #2223] Improved reliability of migration
5cad626
damienallen added a commit that referenced this issue Jun 27, 2016
@damienallen
Revert "[Fixes #2223] Improved reliability of migration"
e56a076 
This reverts commit 5cad626.
damienallen added a commit that referenced this issue Jun 27, 2016
@damienallen
[Fixes #2223] Improved reliability of migration (without unintentiona…
c1045c4 
…l JS changes)
KasperBrandt added a commit that referenced this issue Jun 27, 2016
@KasperBrandt
[#2223] Merge develop into branch
e673a8f
KasperBrandt added a commit that referenced this issue Jun 27, 2016
@KasperBrandt
[#2223] Removed comment of old migration
84a50ce
KasperBrandt added a commit that referenced this issue Jun 27, 2016
@KasperBrandt
Merge pull request #2258 from akvo/#2223-sector-codes
ffb062f 
[#2223] Sector code improvements
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damienallen damienallen

Labels
Type: Project editor
Projects
RSR
Archived in project
Milestone
3.15 Suva
Development

No branches or pull requests
2 participants
@KasperBrandt @damienallen