Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update actual values of parent through project editor #2307

Closed
KasperBrandt opened this issue Jul 21, 2016 · 1 comment
Closed

Update actual values of parent through project editor #2307

KasperBrandt opened this issue Jul 21, 2016 · 1 comment
Assignees
@KasperBrandt
Labels
Type: Results framework
Milestone
3.15 Suva

Comments

@KasperBrandt
Copy link
Contributor

Currently, the actual values only of a parent project only get updated when an indicator update is placed in the 'My results' section. However, adding or changing the value in the project editor should give the same result.
@KasperBrandt KasperBrandt added this to the 3.15 Suva milestone Jul 21, 2016
@KasperBrandt KasperBrandt self-assigned this Jul 21, 2016
@KasperBrandt KasperBrandt removed this from the 3.15 Suva milestone Jul 21, 2016
damienallen added a commit that referenced this issue Jul 25, 2016
@damienallen
[Fixes #2307] Function to update parent period actual values
c37e89b
damienallen added a commit that referenced this issue Jul 25, 2016
@damienallen
[Fixes #2307] Updated conditionals and function parameters
b92b56a
@damienallen damienallen self-assigned this Jul 26, 2016
damienallen added a commit that referenced this issue Jul 26, 2016
@damienallen
[Fixes #2307] Scrapped a lot of useless code, added some arguments
9de5c74
@damienallen damienallen mentioned this issue Jul 26, 2016
Merged
@damienallen
Copy link
Contributor

damienallen commented Jul 26, 2016 •
edited by KasperBrandt
Loading

Test plan

  • Updates made in project editor should aggregate (both units and percentage)
  • update_actual_value should never enter an infinite loop (due to update_parents argument)
  • Ensure existing aggregation functionality still works
    • Aggregation toggles
    • Switching between numerical and non-numerical values
    • Deleting updates

@KasperBrandt KasperBrandt added this to the 3.15 Suva milestone Jul 26, 2016
KasperBrandt added a commit that referenced this issue Jul 26, 2016
@KasperBrandt
[#2307] Remove print statements
c8ac5e2
KasperBrandt added a commit that referenced this issue Jul 26, 2016
@KasperBrandt
[#2307] Change parents() to parents_all() in editor
f733a83
KasperBrandt added a commit that referenced this issue Jul 26, 2016
@KasperBrandt
Merge pull request #2311 from akvo/#2307-update-actual-values
8d97341 
[#2307] Update actual values entered in project editor
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KasperBrandt KasperBrandt

Labels
Type: Results framework
Projects
RSR
Archived in project
Milestone
3.15 Suva
Development

No branches or pull requests
3 participants
@KasperBrandt @damienallen @nadiagorchakova