-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy update text to actual value comment field #2342
Comments
A bit of context: Currently, the IATI field 'Actual Value comment' (actual_comment) is not available for input through My RSR - My results. Instead, there is a field 'Value Description' there. If a user inputs comment for a chosen indicator value in 'Value Description', it does not update actual_comment. Since these two fields have similar purpose, user input in 'Value Description' should be defaulted in 'Actual Value comment' (actual_comment). This way, it can be further used in IATI reporting. |
Hi @punchagan , I'll try to answer your questions: Question: The requirement states that the text of the latest update should be copied to the actual_comment field of the indicator period. Not sure if copy here means, an overwrite of the older text or an append to the existing text. Answer: There will be no text in the actual_comment before copying as it was not made available for user input through My RSR - My results. So actual_comment should be defaulted from 'Value Description' field in My Results Question: Results can have child results, and Indicators for these results therefore have corresponding children. Parent Indicator values can get aggregated from child Indicator values. But, this doesn't happen with comments. So, I presume this behavior shouldn't change and the actual_comment of only the Indicator Period should get updated without any changes to any of its parents. Answer: Yes, you're right. Only the actual_comment of the corresponding Indicator Period should get updated. |
Our original assumption was that project officers would add one update per period (hence only one actual comment). But since there is a technical possibility to add multiple updates per period, let's agree that we append them. |
Prepend the text of an update to the corresponding indicator period's `actual_comment` field. Older comments may get stripped off, if the length of all comment exceeds 2k chars.
When placing an update in the results framework, the text of the (latest) update should be copied to the
actual_comment
field of the indicator period.The text was updated successfully, but these errors were encountered: