Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy update text to actual value comment field #2342

Closed
KasperBrandt opened this issue Aug 25, 2016 · 4 comments
Closed

Copy update text to actual value comment field #2342

KasperBrandt opened this issue Aug 25, 2016 · 4 comments

Comments

@KasperBrandt
Copy link
Contributor

When placing an update in the results framework, the text of the (latest) update should be copied to the actual_comment field of the indicator period.

@nadiagorchakova
Copy link
Contributor

A bit of context:

Currently, the IATI field 'Actual Value comment' (actual_comment) is not available for input through My RSR - My results. Instead, there is a field 'Value Description' there. If a user inputs comment for a chosen indicator value in 'Value Description', it does not update actual_comment. Since these two fields have similar purpose, user input in 'Value Description' should be defaulted in 'Actual Value comment' (actual_comment). This way, it can be further used in IATI reporting.

@nadiagorchakova
Copy link
Contributor

nadiagorchakova commented Sep 9, 2016

Hi @punchagan , I'll try to answer your questions:

Question: The requirement states that the text of the latest update should be copied to the actual_comment field of the indicator period. Not sure if copy here means, an overwrite of the older text or an append to the existing text.

Answer: There will be no text in the actual_comment before copying as it was not made available for user input through My RSR - My results. So actual_comment should be defaulted from 'Value Description' field in My Results

Question: Results can have child results, and Indicators for these results therefore have corresponding children. Parent Indicator values can get aggregated from child Indicator values. But, this doesn't happen with comments. So, I presume this behavior shouldn't change and the actual_comment of only the Indicator Period should get updated without any changes to any of its parents.

Answer: Yes, you're right. Only the actual_comment of the corresponding Indicator Period should get updated.

@punchagan
Copy link
Contributor

Question: The requirement states that the text of the latest update should be copied to the actual_comment field of the indicator period. Not sure if copy here means, an overwrite of the older text or an append to the existing text.

Answer: There will be no text in the actual_comment before copying as it was not made available for user input through My RSR - My results. So actual_comment should be defaulted from 'Value Description' field in My Results

Once the functionality of copying the text from an update to the Indicator Period is added, there will be text in the actual_comment field of the Indicator Period. (Even before, text could be added when the Indicator Period was created from the Project Editor).
mon sep 12 16 43 26 ist 2016

Once the update (with the text More Amazing things happened) is approved, should the original text Something amazing happened be appended to or overwritten?

@nadiagorchakova
Copy link
Contributor

Our original assumption was that project officers would add one update per period (hence only one actual comment). But since there is a technical possibility to add multiple updates per period, let's agree that we append them.

punchagan added a commit that referenced this issue Sep 16, 2016
Prepend the text of an update to the corresponding indicator period's
`actual_comment` field.  Older comments may get stripped off, if the
length of all comment exceeds 2k chars.
@nadiagorchakova nadiagorchakova added this to the 3.16 Tegucigalpa milestone Sep 20, 2016
zzgvh added a commit that referenced this issue Sep 23, 2016
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants