Mandatory fields in Project Focus (My RSR Project Editor)

[nadiagorchakova]

I encountered the following issue in RSR Test env:

1. Fields 'Policy Marker' and 'Policy Marker Significance' fields are not marked as mandatory until you fill them in.
2. Even after you fill in all mandatory fields, the progress bar for the section stays yellow.

This is true when IATI or DGIS standard was checked in the Project settings.

Please review. Thanks!

[nadiagorchakova]

Same thing in RSR UAT env.
You can have a look at these (unpublished) projects:
RSR Test: http://rsr.test.akvo.org/en/myrsr/project_editor/4521/
RSR UAT: http://rsr.uat.akvo.org/en/myrsr/project_editor/4005/

[nadiagorchakova]

Annabelle found same issue in RSR Live (Watershed)
http://rsr.akvo.org/en/myrsr/project_editor/4367/

[zzgvh]

Looking both here and here I cannot find that Policy marker should be mandatory. Sector seems to be the only classification that's required. But I've only done a quick read. Or do we have special rule sets that go above the IATI requirements?

[nadiagorchakova]

Gabriel, you're right! Geert has just changed the settings in http://rsr.test.akvo.org/en/admin/, so now only sector is mandatory. The completion bar is yellow, not matter how many fields you enter though.

[gabemart]

After having a look, I agree with theory of @zzgvh that this behaviour is caused by rsr_policymarker.policy and rsr_policymarker.significance being set to "read only" in the admin interface

This status is not implemented in the project editor, or in the project_editor.py template tag. mandatory_or_hidden only checks for validation_action values of "1" or "2", but "readonly" sets a validation action of "3".

If we wanted to implement this, we would have to edit mandatory_or_hidden to add something like a "readonly-{0}" class when the action is 3, and then edit the project editor to give elements with that class a readonly html attribute of "true". We could base this on markMandatoryFields which works in a very similar way.

If we don't want to implement this, we just need to disable "Read only" as an option in the django admin

[zzgvh]

A note for the deployment of this fix. Check that there are no validations set to Read-only. If there are any they should be removed before deploying, as they will break the admin page for project editor validation sets.

[zzgvh]

Fixed in #2357