Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IATI XML import may fail partially if Currency doesn't already exist #2382

Closed
punchagan opened this issue Sep 28, 2016 · 1 comment
Closed

IATI XML import may fail partially if Currency doesn't already exist #2382

punchagan opened this issue Sep 28, 2016 · 1 comment
Assignees
@punchagan
Labels
Bug Type: IATI
Milestone
3.17 Ulaanbaatar

Comments

@punchagan
Copy link
Contributor

Adding an assertion self.assertEqual(project_v2.transactions.count(), 1) to akvo.rsr.tests.iati_import.test_iati_import.IatiImportTestCase.test_iati_v2_import causes the test to fail.
@punchagan punchagan self-assigned this Sep 28, 2016
punchagan added a commit that referenced this issue Sep 28, 2016
@punchagan
[#2382] transaction.iati_currency() can be string
dec4d21 
codelist_value sometimes returns strings, and strings don't have name
attributes.  This causes the transactions to be failed to be imported in
the IATI import tests.
punchagan added a commit that referenced this issue Sep 28, 2016
@punchagan
[#2382] Fix import of planned disbursements
06968a6
punchagan added a commit that referenced this issue Sep 28, 2016
@punchagan
[#2382] Add more assertions to iati import test
f6878d7
punchagan added a commit that referenced this issue Sep 28, 2016
@punchagan
[#2382] Use get_codelist_value_name everywhere
7243df9
punchagan added a commit that referenced this issue Sep 28, 2016
@punchagan
[#2382] Use get_codelist_value_name everywhere
81df4e0
zzgvh added a commit that referenced this issue Oct 6, 2016
@zzgvh
[#2382] Fix name lookup of transaction currency
38bb8d1 
The lookup of the transaction currency name from the codelist is incorrectly using utils.codelist_value. Fix by using utils.codelist_name() and also simplify Transaction.__unicode__().
zzgvh added a commit that referenced this issue Oct 6, 2016
@zzgvh
[#2382] Add tests to iati import of transactions
1ebc64d 
Specifically to test the transaction currency name lookup.
punchagan added a commit that referenced this issue Oct 6, 2016
@punchagan
Merge pull request #2395 from akvo/#2382_fix_currency_name_lookup
5de6611 
#2382 fix currency name lookup
@punchagan punchagan added this to the 3.17 Ulaanbaatar milestone Oct 6, 2016
@punchagan
Copy link
Contributor Author

Fixed in #2395

@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punchagan punchagan

Labels
Bug Type: IATI
Projects
RSR
Archived in project
Milestone
3.17 Ulaanbaatar
Development

No branches or pull requests
1 participant
@punchagan