Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Landscape code quality tests with flake8 and/or pylint #2477

Closed
punchagan opened this issue Dec 5, 2016 · 0 comments · Fixed by #2363
Closed

Replace Landscape code quality tests with flake8 and/or pylint #2477

punchagan opened this issue Dec 5, 2016 · 0 comments · Fixed by #2363
Assignees
@punchagan
Labels
Chore

Comments

@punchagan
Copy link
Contributor

Landscape doesn't seem to always run, and sometimes just hangs on some pull-requests without any reason. It might be easier to just run our own linting/checking tool on Travis.
@punchagan punchagan added the Chore label Dec 5, 2016
@punchagan punchagan self-assigned this Dec 5, 2016
punchagan added a commit that referenced this issue Dec 6, 2016
@punchagan
[#2477] Remove unused imports
ebdd5bb 
Used the autoflake tool and ran the following command:

    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs autoflake -i -r --remove-all-unused-imports
punchagan added a commit that referenced this issue Dec 6, 2016
@punchagan
[#2477] Remove unused variables
b89121a 
Ran the following command and made some minor manual edits:

    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs autoflake -i -r --remove-unused-variables
punchagan added a commit that referenced this issue Dec 6, 2016
@punchagan
[#2477] Fix a bunch of whitespace related issues
8b080f1 
    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs \
    autopep8 -i --select E231,E203,E225,E226,W291,E228,E201,E202,W293,E302,E301,W391
punchagan added a commit that referenced this issue Dec 6, 2016
@punchagan
[#2477] Fix a bunch of whitespace and indentation issues
56e4c28 
    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs \
    autopep8 -i --select \
    E221,E241,E251,E271,E272,E115,E122,E123,E124,E125,E126,E127,E128,E231,E203,E225,E226,W291,E228,E201,E202,W293
punchagan added a commit that referenced this issue Dec 6, 2016
@punchagan
[#2477] Fix minor import, comment and space character issues
7199fde 
    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs autopep8 -i --select E261,E265,E266,E221,E241,E251,E271,E272,E401,E402,E403,E405
punchagan added a commit that referenced this issue Dec 6, 2016
@punchagan
[#2477] Fix all errors automatically fixable
935c3cc 
    find akvo/scripts/ -name "*.py"|xargs autopep8 -i --ignore E501
punchagan added a commit that referenced this issue Dec 6, 2016
@punchagan
[#2477] A bunch of hand-made changes to get no flake8 errors
3188df6
punchagan added a commit that referenced this issue Dec 6, 2016
@punchagan
[#2477] Add flake8 checks in CI
4fc77cd 
- The checks will run automatically on Travis.

- Getting a 100% coverage will require significantly more effort and
  work, but having flake8 checks can give us some of the benefits for a
  relatively low cost.  Issues like #2361 can easily be avoided.
punchagan added a commit that referenced this issue Dec 6, 2016
@punchagan
[#2477] Ensure that flake8 is installed on Travis
58f014f
@punchagan punchagan added this to the 3.20 Bogotá milestone Dec 6, 2016
@punchagan punchagan mentioned this issue Dec 6, 2016
Merged
punchagan added a commit that referenced this issue Dec 20, 2016
@punchagan
[#2477] Remove unused imports
4679734 
Used the autoflake tool and ran the following command:

    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs autoflake -i -r --remove-all-unused-imports
punchagan added a commit that referenced this issue Dec 20, 2016
@punchagan
[#2477] Remove unused variables
d82d7a1 
Ran the following command and made some minor manual edits:

    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs autoflake -i -r --remove-unused-variables
punchagan added a commit that referenced this issue Dec 20, 2016
@punchagan
[#2477] Fix a bunch of whitespace related issues
437c32d 
    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs \
    autopep8 -i --select E231,E203,E225,E226,W291,E228,E201,E202,W293,E302,E301,W391
punchagan added a commit that referenced this issue Dec 20, 2016
@punchagan
[#2477] Fix a bunch of whitespace and indentation issues
ff4e9f1 
    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs \
    autopep8 -i --select \
    E221,E241,E251,E271,E272,E115,E122,E123,E124,E125,E126,E127,E128,E231,E203,E225,E226,W291,E228,E201,E202,W293
punchagan added a commit that referenced this issue Dec 20, 2016
@punchagan
[#2477] Fix minor import, comment and space character issues
e10f36f 
    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs autopep8 -i --select E261,E265,E266,E221,E241,E251,E271,E272,E401,E402,E403,E405
punchagan added a commit that referenced this issue Dec 20, 2016
@punchagan
[#2477] Fix all errors automatically fixable
680d54c 
    find akvo/scripts/ -name "*.py"|xargs autopep8 -i --ignore E501
punchagan added a commit that referenced this issue Dec 20, 2016
@punchagan
[#2477] A bunch of hand-made changes to get no flake8 errors
59544f9
punchagan added a commit that referenced this issue Dec 20, 2016
@punchagan
[#2477] Add flake8 checks in CI
ba767ea 
- The checks will run automatically on Travis.

- Getting a 100% coverage will require significantly more effort and
  work, but having flake8 checks can give us some of the benefits for a
  relatively low cost.  Issues like #2361 can easily be avoided.
punchagan added a commit that referenced this issue Dec 20, 2016
@punchagan
[#2477] Ensure that flake8 is installed on Travis
65ebc92
@punchagan punchagan removed this from the 3.20 Bogotá milestone Dec 27, 2016
punchagan added a commit that referenced this issue Feb 21, 2017
@punchagan
[#2477] Remove unused imports
12c3514 
Used the autoflake tool and ran the following command:

    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs autoflake -i -r --remove-all-unused-imports
punchagan added a commit that referenced this issue Feb 21, 2017
@punchagan
[#2477] Remove unused variables
3843e53 
Ran the following command and made some minor manual edits:

    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs autoflake -i -r --remove-unused-variables
punchagan added a commit that referenced this issue Feb 21, 2017
@punchagan
[#2477] Fix a bunch of whitespace related issues
7a4a556 
    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs \
    autopep8 -i --select E231,E203,E225,E226,W291,E228,E201,E202,W293,E302,E301,W391
punchagan added a commit that referenced this issue Feb 21, 2017
@punchagan
[#2477] Fix a bunch of whitespace and indentation issues
7f03671 
    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs \
    autopep8 -i --select \
    E221,E241,E251,E271,E272,E115,E122,E123,E124,E125,E126,E127,E128,E231,E203,E225,E226,W291,E228,E201,E202,W293
punchagan added a commit that referenced this issue Feb 21, 2017
@punchagan
[#2477] Fix minor import, comment and space character issues
5727e4b 
    find akvo/ -name "*.py" |grep -v __init__.py|grep -v migration|xargs autopep8 -i --select E261,E265,E266,E221,E241,E251,E271,E272,E401,E402,E403,E405
punchagan added a commit that referenced this issue Feb 21, 2017
@punchagan
[#2477] Fix all errors automatically fixable
5148752 
    find akvo/scripts/ -name "*.py"|xargs autopep8 -i --ignore E501
punchagan added a commit that referenced this issue Feb 21, 2017
@punchagan
[#2477] A bunch of hand-made changes to get no flake8 errors
53ce0e5
punchagan added a commit that referenced this issue Feb 21, 2017
@punchagan
[#2477] Add flake8 checks in CI
920fa90 
- The checks will run automatically on Travis.

- Getting a 100% coverage will require significantly more effort and
  work, but having flake8 checks can give us some of the benefits for a
  relatively low cost.  Issues like #2361 can easily be avoided.
punchagan added a commit that referenced this issue Feb 21, 2017
@punchagan
[#2477] Ensure that flake8 is installed on Travis
6e18c49
punchagan added a commit that referenced this issue Feb 21, 2017
@punchagan
[#2477] Fix flake8 error in a recent change
09d78a6
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punchagan punchagan

Labels
Chore
Projects
RSR
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add flake8 checks akvo/akvo-rsr
1 participant
@punchagan