Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projects directory listing only shows 10 projects #2540

Closed
punchagan opened this issue Feb 17, 2017 · 0 comments
Closed

Projects directory listing only shows 10 projects #2540

punchagan opened this issue Feb 17, 2017 · 0 comments
Assignees
@punchagan
Labels
Type: Performance
Milestone
3.22 Chisinau

Comments

@punchagan
Copy link
Contributor

The project listing directory is hard coded to show only 10 projects. This limit seems to be in place due to some changes made in #1258 and may not be necessary any more.
@punchagan punchagan self-assigned this Feb 17, 2017
punchagan added a commit that referenced this issue Feb 17, 2017
@punchagan
[#2540] Allow listing more projects in the directory
7e81e78 
The query for `partnership_more_link` is very slow, and adding a
`select_related` makes it quite a lot faster.  This looks like the only query
that is slow on the project listing page.

We add a `limit` parameter to specify the number of projects to be listed in
the directory, with the default value being 10.

Closes #2540
@punchagan punchagan mentioned this issue Feb 17, 2017
Merged
5 tasks
punchagan added a commit that referenced this issue Feb 17, 2017
@punchagan
[#2540] Prefetch budget_items for projects
d209c8a 
And optimize check for multiple currencies in a project
punchagan added a commit that referenced this issue Feb 17, 2017
@punchagan
[#2540] Add caching to codelist_value utility function
f516472 
And refactor codelist_name function to use this.  These functions are called in
so many places, that caching them should bring significant benefits all over
the site.

RSR seems to already have memcached configured and it's a shame that we don't
use it anywhere except for thumbnails.  A lot of things can benefit from caching!
punchagan added a commit that referenced this issue Feb 17, 2017
@punchagan
[#2540] Remove dead middleware code
59d960e
punchagan added a commit that referenced this issue Feb 20, 2017
@punchagan
[#2540] Try starting memcached on Travis
aee4357
punchagan added a commit that referenced this issue Feb 20, 2017
@punchagan
[#2540] Add a skipped test using django_perf_rec
e91a495 
Added a simple performance test example for the project directory listing, but
the test cannot be run with the current version of Django.  It can be
un-skipped when Django is updated!
@punchagan punchagan added this to the 3.22 Chisinau milestone Feb 21, 2017
punchagan added a commit that referenced this issue Feb 23, 2017
@punchagan
[#2540] Allow listing more projects in the directory
99a6192 
The query for `partnership_more_link` is very slow, and adding a
`select_related` makes it quite a lot faster.  This looks like the only query
that is slow on the project listing page.

We add a `limit` parameter to specify the number of projects to be listed in
the directory, with the default value being 10.

Closes #2540
punchagan added a commit that referenced this issue Feb 23, 2017
@punchagan
[#2540] Prefetch budget_items for projects
3853a7c 
And optimize check for multiple currencies in a project
punchagan added a commit that referenced this issue Feb 23, 2017
@punchagan
[#2540] Add caching to codelist_value utility function
904d774 
And refactor codelist_name function to use this.  These functions are called in
so many places, that caching them should bring significant benefits all over
the site.

RSR seems to already have memcached configured and it's a shame that we don't
use it anywhere except for thumbnails.  A lot of things can benefit from caching!
punchagan added a commit that referenced this issue Feb 23, 2017
@punchagan
[#2540] Remove dead middleware code
90752fd
punchagan added a commit that referenced this issue Feb 23, 2017
@punchagan
[#2540] Try starting memcached on Travis
db20a5c
punchagan added a commit that referenced this issue Feb 23, 2017
@punchagan
[#2540] Add a skipped test using django_perf_rec
67c133c 
Added a simple performance test example for the project directory listing, but
the test cannot be run with the current version of Django.  It can be
un-skipped when Django is updated!
punchagan added a commit that referenced this issue Feb 23, 2017
@punchagan
[#2540] Prefetch budget_items for projects
d8e4271 
And optimize check for multiple currencies in a project
punchagan added a commit that referenced this issue Feb 23, 2017
@punchagan
[#2540] Add caching to codelist_value utility function
90385b5 
And refactor codelist_name function to use this.  These functions are called in
so many places, that caching them should bring significant benefits all over
the site.

RSR seems to already have memcached configured and it's a shame that we don't
use it anywhere except for thumbnails.  A lot of things can benefit from caching!
punchagan added a commit that referenced this issue Feb 23, 2017
@punchagan
[#2540] Remove dead middleware code
1e62cff
punchagan added a commit that referenced this issue Feb 23, 2017
@punchagan
[#2540] Try starting memcached on Travis
7f8401f
punchagan added a commit that referenced this issue Feb 23, 2017
@punchagan
[#2540] Add a skipped test using django_perf_rec
a034dcf 
Added a simple performance test example for the project directory listing, but
the test cannot be run with the current version of Django.  It can be
un-skipped when Django is updated!
zzgvh added a commit that referenced this issue Mar 8, 2017
@zzgvh
Merge pull request #2541 from akvo/#2540-more-projects
0dd0f9d 
[#2540] Allow listing more projects in the directory
Code reviewed
@zzgvh zzgvh removed the Needs Review label Mar 8, 2017
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punchagan punchagan

Labels
Type: Performance
Projects
RSR
Archived in project
Milestone
3.22 Chisinau
Development

No branches or pull requests
2 participants
@zzgvh @punchagan