Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with saving new project to RSR #313

Closed
CharlotteSoed opened this issue Sep 23, 2013 · 9 comments
Closed

Problems with saving new project to RSR #313

CharlotteSoed opened this issue Sep 23, 2013 · 9 comments

Comments

@CharlotteSoed
Copy link

When saving (changes in) a (new) project in RSR it seems to get stuck. I waited for a few minutes, but RSR doesn't seem to respond. Yes, I did hit the save button a few times because didn't know what to do other than closing the page and loose all info that was just added….

When going back into the project it has created many of the same partners (see screenshot)

screen shot 2013-09-23 at 11 45 36 am

This is project 1351

@ghost ghost assigned osg74 and peeb Sep 23, 2013
@peeb
Copy link
Contributor

peeb commented Sep 23, 2013

A proposed workaround to this is to grey out the Save button or to give some other form of blocking visual feedback.

@osg74
Copy link

osg74 commented Sep 23, 2013

We should also consider using a more responsive and modern Django admin UI like http://djangosuit.com

@zzgvh
Copy link
Contributor

zzgvh commented Sep 23, 2013

I don't think django-suit would help in that respect, it's mostly a bootstrap based skinning of the admin (I think).

@CharlotteSoed
Copy link
Author

no, within the 1 project a multitude of the same partners were created (for as far as I can see). Have had this issue before btw - exact same thing.

@peeb
Copy link
Contributor

peeb commented Oct 16, 2013

Is this issue masking the bigger issue that the save is taking a really long time?

peeb added a commit that referenced this issue Oct 17, 2013
[#313] Added jQuery to grey out submit buttons after click event.
@adriancollier
Copy link
Contributor

Reviewed

@rumca rumca reopened this Oct 30, 2013
@rumca
Copy link
Contributor

rumca commented Oct 30, 2013

When a user is adding a project which should throw an error on field validation (such as blank mandatory fields, or surpassing the character limit on text boxes), after clicking "Save" there is no error thrown, the button becomes greyed out and there is no way to progress.

Note - the same result occurs when a user tries to add a project full stop (not sure if adding the onClick then grey out has wiped the submit function or something?)

@peeb
Copy link
Contributor

peeb commented Nov 6, 2013

Still to verify that this prevents undesirable knock-on behaviour with other input UI elements.

peeb added a commit that referenced this issue Nov 6, 2013
…ubmit-row. This should catch all input buttons regardless of what labels or names they have.
peeb added a commit that referenced this issue Nov 6, 2013
peeb added a commit that referenced this issue Nov 6, 2013
…er just a visual clue that she should not click repeatedly on the save buttons.
@rumca
Copy link
Contributor

rumca commented Nov 6, 2013

Issue with adding new projects now resolved,

@rumca rumca closed this as completed Nov 6, 2013
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

6 participants