-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyperlinks in RSR update #419
Comments
This appears to be an issue with links following a line break. I have done this several times within an update http://rsr.test.akvo.org/project/1113/update/4101/ and it seems the link is only identified by the Markdown formatting if there are characters between the beginning of the link and the preceding line break. It does not work with spaces at the beginning of the line - although lots of spaces turns the link into a block of code... I have no idea how we would go about solving this though. I'm not sure what we use to process the formatting, or if we have "customisation" options for this. |
Just a bit odd to have to explain to partners this is how it works.. |
Tested the issue described with the code from #438 and it seems to help the trailing urls to. |
When an updates only consisted of a link that would not get urlized. We have to do some escape dancing to make sure urls are urlized by Django & that markdown works properly. And at the same time be safe and not allow things like <script>alert('unsafe');</script> to be evaluated.
When an updates only consisted of a link that would not get urlized. We have to do some escape dancing to make sure urls are urlized by Django & that markdown works properly. And at the same time be safe and not allow things like <script>alert('unsafe');</script> to be evaluated.
Tested on UAT and PartnerSite UAT - working as expected |
Just found out that a link in an update only becomes a clickable hyperlink if its pasted right after a sentence. If there is an ENTER after the sentence the link doesn't become a hyperlink.
Could you adjust this so that a link always becomes a hyperlink, regardless where its placed in an update?
Cheers
The text was updated successfully, but these errors were encountered: