Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinks in RSR update #419

Closed
CharlotteSoed opened this issue Dec 31, 2013 · 4 comments
Closed

Hyperlinks in RSR update #419

CharlotteSoed opened this issue Dec 31, 2013 · 4 comments

Comments

@CharlotteSoed
Copy link

Just found out that a link in an update only becomes a clickable hyperlink if its pasted right after a sentence. If there is an ENTER after the sentence the link doesn't become a hyperlink.

Could you adjust this so that a link always becomes a hyperlink, regardless where its placed in an update?

Cheers

@adriancollier
Copy link
Contributor

This appears to be an issue with links following a line break. I have done this several times within an update http://rsr.test.akvo.org/project/1113/update/4101/ and it seems the link is only identified by the Markdown formatting if there are characters between the beginning of the link and the preceding line break.

It does not work with spaces at the beginning of the line - although lots of spaces turns the link into a block of code...

I have no idea how we would go about solving this though. I'm not sure what we use to process the formatting, or if we have "customisation" options for this.

@CharlotteSoed
Copy link
Author

Just a bit odd to have to explain to partners this is how it works..

@kardan
Copy link
Contributor

kardan commented Feb 5, 2014

Tested the issue described with the code from #438 and it seems to help the trailing urls to.

@kardan kardan added this to the 2.3.4 Tamarine milestone Feb 26, 2014
kardan added a commit that referenced this issue Mar 10, 2014
When an updates only consisted of a link that would
not get urlized. We have to do some escape dancing to
make sure urls are urlized by Django & that markdown
works properly. And at the same time be safe and not
allow things like <script>alert('unsafe');</script>
to be evaluated.
kardan added a commit that referenced this issue Mar 10, 2014
When an updates only consisted of a link that would
not get urlized. We have to do some escape dancing to
make sure urls are urlized by Django & that markdown
works properly. And at the same time be safe and not
allow things like <script>alert('unsafe');</script>
to be evaluated.
@rumca rumca added Bug labels Mar 10, 2014
@rumca
Copy link
Contributor

rumca commented Mar 10, 2014

Tested on UAT and PartnerSite UAT - working as expected

@rumca rumca closed this as completed Mar 10, 2014
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants