Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Org Update Import #451

Closed
adriancollier opened this issue Feb 27, 2014 · 1 comment
Closed

API Org Update Import #451

adriancollier opened this issue Feb 27, 2014 · 1 comment
Assignees
@zzgvh
Milestone
2.3.4 Tamarine

Comments

@adriancollier
Copy link
Contributor

We made the Org import, but we were only updating the Location and Logo of existing orgs. We need to ensure that all information included within the incoming file is updated when it is provided.

@zzgvh you have the details of this already.
@adriancollier adriancollier added this to the 2.3.4 Tamarine milestone Feb 27, 2014
zzgvh added a commit that referenced this issue Feb 28, 2014
@zzgvh
[#451] Add org_data_from_xml()
05dfdaf 
org_data_from_xml() is a more general way to get from the etree
representation of the data to the dictionary needed in the Django ORM.

The core idea is to use an initial dict that holds the Organisation
field names as keys and the xpath expressions for getting the data from
the etree as values. After running the xpath part using calls to
data_from_xpaths() post processing of fields that need to be transformed
from the raw data is made.
zzgvh added a commit that referenced this issue Feb 28, 2014
@zzgvh
[#451] Add update_organisation() and add logging for creation of
45244dd 
internal ID

update_organisation() updates an exising organisation with the data
from the XML. This was missing from the previous version of pre_import.

Also add logging for when an InternalOrganisationID is created and
refactor create_new_organisation() to use org_data_from_xml().
zzgvh added a commit that referenced this issue Feb 28, 2014
@zzgvh
[#451] PEP 8 edits
8afeb8f 
Remove space around "=" in calls to dict()
@adriancollier
Copy link
Contributor Author

@zzgvh confirmed working well in UAT.

@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zzgvh zzgvh

Labels
None yet
Projects
RSR
Archived in project
Milestone
2.3.4 Tamarine
Development

No branches or pull requests
2 participants
@zzgvh @adriancollier