Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project view in admin field issue #458

Closed
rumca opened this issue Mar 10, 2014 · 5 comments
Closed

Add project view in admin field issue #458

rumca opened this issue Mar 10, 2014 · 5 comments
Assignees
@zzgvh
Labels
Bug Type: Permissions
Milestone
2.3.4 Tamarine

Comments

@rumca
Copy link
Contributor

rumca commented Mar 10, 2014

I suspect this is to do with the new Timestamp field. A few of the fields have been messed up slightly in the latest release - for example add project location now tacked on to the photo section and then the budget section has the location header:

fieldmessup
@rumca rumca added this to the 2.3.4 Tamarine milestone Mar 10, 2014
zzgvh added a commit that referenced this issue Mar 10, 2014
@zzgvh
[#381 #458] Display timestamps in the admin for relevant models
8cb18c6 
Using the TimestampsAdminDisplayMixin add the display of timestamp
fields to Organisation, Project, ProjectUpdate and PartnerSite model
admins.

Change where the fields are displayed to kill bug #458 that happened
when the timestamp fields had their own fieldset that was only shown
when there was any timestamp data.
zzgvh added a commit that referenced this issue Mar 10, 2014
@zzgvh
[#458] Cleanup of organisation/change_form.html
e4ab219 
The organisation/change_form.html had some code still from when it
showed internal organisation IDs thata was removed.
@rumca rumca added Bug labels Mar 10, 2014
@rumca
Copy link
Contributor Author

rumca commented Mar 10, 2014

Tested on UAT and issue has been fixed. Just awaiting code review before closing.

@adriancollier
Copy link
Contributor

Looks fine - with the code check I'm wondering if we should keep all the lines we're commenting out here: 8cb18c6#diff-37323ecbc3845b8a85c15f7b09483ab1R1202 or if we should just remove this. @zzgvh is it useful to have this there for reference?

@zzgvh
Copy link
Contributor

zzgvh commented Mar 11, 2014

There used to be two fieldset definitions, one that was used for Akvo staff users and one for partner users. But with the addition of the timestamp fields the mechanics for how those fields and the notes field are shown/hidden has been changed and generalized to all use the get_fieldsets() method I don't think the old way needs to be there any more. The core fieldset is still there of course:

akvo-rsr/akvo/rsr/admin.py

Line 1181 in 8cb18c6

(u'General', dict(fields=('organisation', 'enabled',))),
.

@zzgvh
Copy link
Contributor

zzgvh commented Mar 11, 2014

However I see there's a commented old version of get_fieldsets() that should have been removed too 😛

@adriancollier
Copy link
Contributor

Thanks - closing

@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zzgvh zzgvh

Labels
Bug Type: Permissions
Projects
RSR
Archived in project
Milestone
2.3.4 Tamarine
Development

No branches or pull requests
3 participants
@zzgvh @adriancollier @rumca