Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Django version to mitigate security vulnerabilities #522

Closed
osg74 opened this issue Apr 22, 2014 · 11 comments
Closed

Upgrade Django version to mitigate security vulnerabilities #522

osg74 opened this issue Apr 22, 2014 · 11 comments
Assignees

Comments

@osg74
Copy link

osg74 commented Apr 22, 2014

We should upgrade to the latest Django 1.4.11 release to patch known security vulnerabilities in the 1.4.x series: https://www.djangoproject.com/weblog/2014/apr/21/security/

@osg74 osg74 added this to the 2.3.7 Watermelon milestone Apr 22, 2014
@KasperBrandt
Copy link
Contributor

@osgl I noticed issue #328 indicates an upgrade to 1.5 or 1.6, so maybe we should skip 1.4.11?

@osg74
Copy link
Author

osg74 commented Apr 23, 2014

Agreed -- upgrading to 1.6.x would be preferable if it's not too painful a jump but at a minimum we should upgrade to 1.4.11 in the next release.

@osg74
Copy link
Author

osg74 commented Apr 23, 2014

The 1.5.0 and 1.6.0 release notes will indicate any significant changes and considerations for upgrading our codebase from 1.4 -> 1.6:
https://docs.djangoproject.com/en/1.5/releases/1.5/
https://docs.djangoproject.com/en/1.6/releases/1.6/

@adriancollier
Copy link
Contributor

Am I right in thinking the best way for us to do this is for us to try it out on a demo environment (Test, UAT or a local dev) and run all the tests to pick out the obvious problems, before then doing a more manual deep dive into some of the more obscure corners of RSR - API, donations, widgets etc, to make sure it's all working as planned?

@osg74
Copy link
Author

osg74 commented Apr 29, 2014

Correct -- I would upgrade to 1.4.11 for now, which will be a minor but critical upgrade so we can at least patch the security vulnerability for the next release. We can then work on the larger task (#328) of upgrading from 1.4 to 1.6 for a later release.

@osg74
Copy link
Author

osg74 commented Apr 29, 2014

@KasperBrandt -- @mtwestra has been upgrading the Water Compass site from Django 1.3 to 1.6 so he could perhaps provide some guidance and warnings as needed.

@mtwestra
Copy link

Hi Oliver and Kasper,

watercompass is not done yet, sanitation compass is
mark

On 29 Apr 2014, at 13:31, Oliver Galloway-Lunn notifications@github.com wrote:

@KasperBrandt -- @mtwestra has been upgrading the Water Compass site from Django 1.3 to 1.6 so he could perhaps provide some guidance and warnings as needed.


Reply to this email directly or view it on GitHub.

@adriancollier
Copy link
Contributor

This will be covered in #544

@osg74 osg74 reopened this May 27, 2014
@osg74
Copy link
Author

osg74 commented May 27, 2014

Going to bump the 1.4 version we're using to 1.4.11 or later to at least plug the security vulnerability until the Django 1.7 upgrade work is ready.

zzgvh added a commit that referenced this issue May 27, 2014
[#522] Upgraded to Django 1.4.13 to plug recent security vulnerabilities
@rumca rumca closed this as completed May 27, 2014
@osg74
Copy link
Author

osg74 commented May 27, 2014

Deployed on rsr.akvouat.org -- ready for integration testing.

@rumca
Copy link
Contributor

rumca commented May 27, 2014

system performed as expected on UAT - no obvious regression issues

@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

6 participants