Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the SMS updates #574

Closed
zzgvh opened this issue May 26, 2014 · 4 comments
Closed

Remove the SMS updates #574

zzgvh opened this issue May 26, 2014 · 4 comments
Milestone
2.3.8 Xylocarp

Comments

@zzgvh
Copy link
Contributor

zzgvh commented May 26, 2014

Remove all code for the SMS project updates functionality, including the gateway app and the MyAkvo templates for the SMS settings.

This is part of #546.
zzgvh added a commit that referenced this issue May 26, 2014
@zzgvh
[#574] Remove code and templates that was used for the SMS updates
021ef66
zzgvh added a commit that referenced this issue May 26, 2014
@zzgvh
[#574] Remove reference to SmsReporter in rsr/management.py
5fda551
zzgvh added a commit that referenced this issue May 26, 2014
@zzgvh
[#574] Merge branch 'feature/django-upgrade' into feature/du574_remov…
e3b42ce 
…e_sms
zzgvh added a commit that referenced this issue May 26, 2014
@zzgvh
[#574] Create migration for the SMS removal
16db9ba 
The migration deletes the SmsReporter model and the phone_number and
validation fields of the UserProfile.

Also remove the fixture that was only populating models used by the SMS
models.
zzgvh added a commit that referenced this issue May 26, 2014
@zzgvh
[#574] Merge branch 'feature/django-upgrade' into feature/du574_remov…
177d710 
…e_sms

Conflicts:
	akvo/templates/notification/notice_settings.html
	akvo/templates/rsr/myakvo/navigation.html
KasperBrandt added a commit that referenced this issue May 26, 2014
@KasperBrandt
Merge pull request #577 from akvo/feature/du574_remove_sms
78dc6e2 
#574 remove sms
@KasperBrandt
Copy link
Contributor

Merged in #577

@adriancollier adriancollier added this to the 2.3.8 Xylocarp milestone Jun 3, 2014
@zzgvh
Copy link
Contributor Author

zzgvh commented Jun 10, 2014

@rumca Test plan: there should be nothing visible left that refers to SMSs (except already created project updates that were sent via SMS).

@zzgvh zzgvh reopened this Jun 10, 2014
@zzgvh zzgvh closed this as completed Jun 10, 2014
@rumca
Copy link
Contributor

rumca commented Jun 12, 2014

@zzgvh it's still possible to add an update through the admin with an "update method" of SMS or mobile. Should we remove that also?

@zzgvh
Copy link
Contributor Author

zzgvh commented Jun 12, 2014

No I don't think so. Apart from messing with it in the admin there's no way to add new updates via SMS, but that list is used for existing updates, and since there are a few that were made via SMS we should keep it.

@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
RSR
Archived in project
Milestone
2.3.8 Xylocarp
Development

No branches or pull requests
4 participants
@zzgvh @adriancollier @KasperBrandt @rumca