Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace get_(add|change|delete)_permission model _meta methods #584

Closed
zzgvh opened this issue May 27, 2014 · 4 comments
Closed

Replace get_(add|change|delete)_permission model _meta methods #584

zzgvh opened this issue May 27, 2014 · 4 comments
Milestone
2.3.8 Xylocarp

Comments

@zzgvh
Copy link
Contributor

zzgvh commented May 27, 2014

The get_(add|change|delete)_permission model _meta methods are being deprecated. Use django.contrib.auth.get_permission_codename instead.
@zzgvh
Copy link
Contributor Author

zzgvh commented May 27, 2014

akvo.utils.get_rsr_limited_change_permission() can also be replaced with get_permission_codename()

zzgvh added a commit that referenced this issue May 27, 2014
@zzgvh
[#584] Replace deprecated perms codenames resolver methods
8cf80e3 
Django 1.6 deprecates Model._meta.get_add_permission(),
.get_change_permission() and .get_delete_permission(). Instead
django.contrib.auth.get_permission_codename() is provided.

Replace the deprecated methods with get_permission_codename().

Remove akvo.utils.get_rsr_limited_change_permission() and replace uses
of it with get_permission_codename().
@zzgvh
Copy link
Contributor Author

zzgvh commented May 27, 2014

This fix requires Django 1.6. Also django-counter needs fixing to work in 1.6 blocking testing before that is done too.

@adriancollier adriancollier added this to the 2.3.8 Xylocarp milestone Jun 3, 2014
zzgvh added a commit that referenced this issue Jun 4, 2014
@zzgvh
[#584] Merge branch 'feature/django-upgrade' into feature/du584_repla…
26350f3 
…ce_perms_codenames_resolver

Conflicts:
	akvo/rsr/admin.py
KasperBrandt added a commit that referenced this issue Jun 4, 2014
@KasperBrandt
Merge pull request #587 from akvo/feature/du584_replace_perms_codenam…
130f572 
…es_resolver

[#584] Replace deprecated perms codenames resolver methods
@KasperBrandt
Copy link
Contributor

Merged in #587

@zzgvh
Copy link
Contributor Author

zzgvh commented Jun 10, 2014

@rumca Test plan: "invisible" change. The code changes are in the admin and the end result should be that everything works as before in terms of who is allowed to see and edit what.

@zzgvh zzgvh reopened this Jun 10, 2014
@zzgvh zzgvh closed this as completed Jun 10, 2014
@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
RSR
Archived in project
Milestone
2.3.8 Xylocarp
Development

No branches or pull requests
3 participants
@zzgvh @adriancollier @KasperBrandt