Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove django-piston Functionality in light of new API being release #61

Closed
osg74 opened this issue Jul 23, 2012 · 6 comments
Closed

Remove django-piston Functionality in light of new API being release #61

osg74 opened this issue Jul 23, 2012 · 6 comments
Assignees
@zzgvh
Labels
Bug
Milestone
2.1.5 Nectarine

Comments

@osg74
Copy link

osg74 commented Jul 23, 2012

We're seeing loads of these "Handler already registered for model Project" errors every few minutes in the Apache error log:

[Mon Jul 23 19:20:12 2012] [error] /var/virtualenvs/current/lib/python2.7/site-packages/piston/handler.py:27: UserWarning: Handler already registered for model Project, you may experience inconsistent results.
[Mon Jul 23 19:20:12 2012] [error] "you may experience inconsistent results." % new_cls.model.name)

This seems to have been a problem for a while as it's also appearing in the live server logs so it doesn't appear to be related to the Python 2.7 upgrade.

After conversation it has been decided that we will depreciate the django-piston library and functionality as we have a new and working API in place.
@ghost ghost assigned zzgvh Jul 23, 2012
@zzgvh
Copy link
Contributor

zzgvh commented Aug 1, 2012

django-piston should be removed when we're removing the old proto-API based on it.

@ghost ghost assigned zzgvh Mar 6, 2013
@adriancollier
Copy link
Contributor

@zzgvh Is this in a suitable state to be included in the next release, or shall we push this one back?

@zzgvh
Copy link
Contributor

zzgvh commented Jul 2, 2013

I think we should remove django-piston. I don't think anyone's using the old API.

zzgvh added a commit that referenced this issue Jul 9, 2013
@zzgvh
[#61] Remove old django-piston based API
025fd18 
Remove the files and pip requirement referring to django piston.

Remove the base URL to the piston based API, /rsr/api.
@zzgvh
Copy link
Contributor

zzgvh commented Jul 9, 2013

Deployed to UAT.

@adriancollier
Copy link
Contributor

We need a code check on this one - @peeb / @osgl can either of you check this?

@adriancollier
Copy link
Contributor

I also believe this went into 2.1.5 - please correct me if I am wrong.

@MichaelAkvo MichaelAkvo moved this to Done in RSR Dec 8, 2022
@MichaelAkvo MichaelAkvo added this to RSR Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zzgvh zzgvh

Labels
Bug
Projects
RSR
Archived in project
Milestone
2.1.5 Nectarine
Development

No branches or pull requests
3 participants
@zzgvh @osg74 @adriancollier