-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server info to response header #749
Comments
Given that the version number is an artefact of the code and not the provisioning environment, I don't think it makes sense to add it to the nginx config. Apart from anything else, you would have to update nginx at the same time as RSR, while if it is done in RSR, the environment does not need to know or care. |
Ok, middleware it is then! |
The middleware adds a response header of the format: X-RSR-Verision: "Tag:<tag name> Commit:<commit hash> Branch:<git branch name>"
What's the status on this? |
Test planGIVEN a request to RSR |
For debugging purposes the Up app (and possibly other clients too) could use the RSR version info, like the one that's visible in the admin.
Suggested implementation of this is as a custom response header using the same format as in the admin:
X-RSR-Version: <version tag> (<commit hash>) [<branch name>]
A small middleware class is one way to implement this across all server responses. But I'd like to hear from @carlio or @osgl if this could be added at an even "lower" level in the webserver configuration.
The text was updated successfully, but these errors were encountered: