PayPal donations not showing on RSR

[KasperBrandt]

It seems like the amount_received and IPN number are not filled in for invoices through PayPal, causing the donation to keep the status 'stale' and not appear on RSR. Even though we do get the money on our PayPal account.

[kardan]

Looks like the signal & function used to handle Paypal payments got lost in the big model organising https://github.com/akvo/akvo-rsr/blob/v2.3.5/akvo/rsr/models.py#L2111 .

[KasperBrandt]

In UAT we have to check whether donations are working again as they should. Other than that, we should update the stale donations. The following should be done per donation:

• invoice.amount_received = invoice.amount - ipn.mc_fee
• invoice.ipn = ipn.txn_id
• invoice.status = 3

[KasperBrandt]

Test plan

GIVEN a PayPal donation
WHEN a donation is made and approved by PayPal
THEN the donation should be completed and visible on RSR

[rumca]

I'm not sure if this is working as expected on UAT or not. The initial donation goes through and shows up on the funding totals as the test plan expects. However the next time the pending invoice update task runs, the invoice is marked as stale and the donation total decreases again.

I had thought that someone mentioned there was an issue with paypal sandbox which stopped this from working correctly - but that it would work as intended in production. Up until now I've been manually updating the invoice in the admin to mark it as complete and update the amount received etc.