Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1333 gulp errors #1337

Merged
merged 3 commits into from
Mar 17, 2015
Merged

1333 gulp errors #1337

merged 3 commits into from
Mar 17, 2015

Conversation

kardan
Copy link
Contributor

@kardan kardan commented Mar 16, 2015

Besides adding plumber this also updates dependencies. Have to admit that I'm no nom expert so I first did npm update which I think updates my global gulp. Then I killed the scripts/devhelpers/node_modules dir and while in scripts/devhelpers issued npm install to get new modules.

If there is an error in a sass file or a jsx file file and row should be printed now.

kardan added 3 commits March 16, 2015 10:23
To prevent transpile errors to kill the watch process, added plumber
that prints erros to std out.
@iperdomo
Copy link
Contributor

Checklist

  • Test plan
  • Copyright header
  • Code formatting

@kardan
Copy link
Contributor Author

kardan commented Mar 16, 2015

@loicsans maybe you want to verify that this solved your issue?

@kardan kardan closed this Mar 16, 2015
@kardan kardan reopened this Mar 16, 2015
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 22dc130 on akvo:1333_gulp_errors into c6b141b on akvo:develop.

KasperBrandt added a commit that referenced this pull request Mar 17, 2015
@KasperBrandt KasperBrandt merged commit d2be13a into develop Mar 17, 2015
@KasperBrandt KasperBrandt deleted the 1333_gulp_errors branch March 17, 2015 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants