Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1351] IATI export v2 #1382

Merged
merged 9 commits into from
Apr 10, 2015
Merged

[#1351] IATI export v2 #1382

merged 9 commits into from
Apr 10, 2015

Conversation

KasperBrandt
Copy link
Contributor

First version of IATI export for v2.01 (see issue for test plan).

@gabemart There's a bit of inline styling in /templates/myrsr/my_iati.html, as well as the use of the udpateComponent class. Could you take a look and fix that properly in the styling files?
Styling in general should be looked at as well btw.

@iperdomo
Copy link
Contributor

Checklist

  • Test plan
  • Copyright header
  • Code formatting

@landscape-bot
Copy link

Code Health
Repository health increased by 10% when pulling 6aa5459 on 1351_iati_export_v2 into 17f4703 on develop.

@landscape-bot
Copy link

Code Health
Repository health increased by 9% when pulling 3b85150 on 1351_iati_export_v2 into ec46ac7 on develop.

@kardan
Copy link
Contributor

kardan commented Apr 8, 2015

To me everything seems to work fine. Might be a good thing to later when tests are in mainline add some testing on valid and invalid "raw data" but that is for later.

kardan added a commit that referenced this pull request Apr 10, 2015
@kardan kardan merged commit 7b0fefe into develop Apr 10, 2015
@kardan kardan deleted the 1351_iati_export_v2 branch April 10, 2015 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants