[#304] Added warning message for updates without text, photo and video

[KasperBrandt]

@zzgvh can you code check?

[zzgvh]

Yep, perfect functionality.

However the world is not as simple as one would wish...

Number one, and this is a constant annoyance for us all, but we'll have to live with it for the time being: there are two sets of templates, one for RSR and one for Partner sites aka Pages. So the functionality needs to be added to the partner site template too 😒 (templates/partner_sites/project/update_form.html). This leads to the question if the script should be made into a separate file, or rather added to an existing one. But in this case I think not, because of:

Number two, the alert box text should be marked for translation. And since we don't run javascript files through the translation machinery it's probably best to have the script inline in the template even if it isn't DRY. Alternatively the JS is split up into two parts; one script file and one inline assignment of the text to a variable. If you do it this way, talk to Daniel about how to get a new .js into our custom asset manager. I actually don't remember.

And a couple of style comments (which are of course at least somewhat personal 😉).

The variable assignments can be done in one go like so:

var text_val=document.forms["add_update_form"]["text"].value,
    photo_val=document.forms["add_update_form"]["photo"].value,
    video_val=document.forms["add_update_form"]["video"].value;

Regardless statements should have an ";" at the end even tho it's not strictly needed (see discussion in Akvo dev chat from yesterday!).

Last, single character variable names should be limited to for loop counters and the like. Even if it's only used once at the next line as is the case with r in this case. Also I think that if (r==true) can be replaced with if (r) since I'm guessing that confirm() returns a boolean.

[KasperBrandt]

@zzgvh Added the translations just as variables and fixed all your comments. Could you check again?

[zzgvh]

Code reviewed, all systems green.