[#258] Added custom return URL text #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As it is right now the new field is not visible in the admin. If we add it we need to also handle the "removal" of a return url text. This would probably be just setting the text to an empty string but we need to make sure template logic operates on that premise. |
|
I'm not sure - what "removal" do you mean? Are there additional things within this admin that need to be taken out? |
|
Ah - good point, I will add this into the issue so we can consider this before we merge this pull request |
|
@kardan Added the field to admin. Not sure if we can easily merge though, because of multiple migrations in the current branches.. |
|
👍 But migration needs to be but into sequential order with develop before merging |
|
My bad, pull request can be merged as is! |
kardan
added a commit
that referenced
this pull request
Apr 28, 2014
[#258] Added custom return URL text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be code checked.