Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#5112] Optimize add_project_to_program API endpoint #5291

Merged
merged 1 commit into from
Jul 10, 2023
Merged

[#5112] Optimize add_project_to_program API endpoint #5291

merged 1 commit into from
Jul 10, 2023

Conversation

zuhdil
Copy link
Contributor

@zuhdil zuhdil commented Jul 10, 2023 •
edited
Loading

TODO / Done

Summarize what has been changed / what has to be done in order to finalize the PR.

  • Refactor add_project_to_program API endpoint
  • Use .bulk_create for all object creations

Test plan

What tests are necessary to ensure this works or doesn't break anything working

  • Unit testing
  • Manual test

Manual testing

  • Create a new L1 contributor on a program with a large results framework
  • Create a new L3 contributor

@coveralls
Copy link
Collaborator

coveralls commented Jul 10, 2023 •
edited
Loading

Coverage Status

coverage: 68.388% (+0.05%) from 68.337% when pulling ac930dd on 5112-contributing-project-creation into 62b617b on master.

@zuhdil zuhdil force-pushed the 5112-contributing-project-creation branch from 36bc852 to ac930dd Compare July 10, 2023 07:59
@zuhdil zuhdil marked this pull request as ready for review July 10, 2023 10:07
@zuhdil zuhdil merged commit 587c25a into master Jul 10, 2023
@zuhdil zuhdil deleted the 5112-contributing-project-creation branch July 10, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zuhdil @coveralls