Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow totally removing categorized tags from users in the affected endpoints #1734

Open
joseAyudarte91 opened this issue Nov 9, 2023 · 0 comments
Open

Allow totally removing categorized tags from users in the affected endpoints #1734

joseAyudarte91 opened this issue Nov 9, 2023 · 0 comments
Assignees
@joseAyudarte91

Comments

@joseAyudarte91
Copy link
Contributor

The code didn't expect this requirement, as offering and seeking tags are required with a minimum of 1 tag per property by the frontend, for each user (stakeholder). However, GPML admins can remove totally expertise-related tags, so the generic tag assignation machinery for users (stakeholders) need to be adapted to that case.
@joseAyudarte91 joseAyudarte91 self-assigned this Nov 9, 2023
joseAyudarte91 added a commit that referenced this issue Nov 9, 2023
@joseAyudarte91
Allow total tags removal from stakeholders
a4e9bdd 
[Re #1734]

As explained in the issue, the generic user (stakeholder) tag
assignation machinery was not ready to allow to remove all the tags of
a given relation-category (offering, seeking or expertise), so now we
have refactored the code to allow so. Since, the tags assignation is a
partial thing (per category), the fix is quite more ellaborated, as we
need to keep the old tags that are not part of the target category, so
those are not overriden.
@joseAyudarte91 joseAyudarte91 mentioned this issue Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joseAyudarte91 joseAyudarte91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joseAyudarte91