Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use AsyncWaitGroup instead of JoinHandles #43

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

al8n
Copy link
Owner

@al8n al8n commented Apr 27, 2024

No description provided.

@al8n al8n self-assigned this Apr 27, 2024
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 98.64865% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 76.00%. Comparing base (a11ad62) to head (ac132fb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   75.83%   76.00%   +0.16%     
==========================================
  Files          64       64              
  Lines        6724     6750      +26     
==========================================
+ Hits         5099     5130      +31     
+ Misses       1625     1620       -5     
Files Coverage Δ
core/src/base.rs 80.85% <100.00%> (+0.20%) ⬆️
core/src/lib.rs 66.66% <ø> (-2.57%) ⬇️
core/src/network/packet/handler.rs 75.60% <100.00%> (-3.88%) ⬇️
core/src/network/packet/listener.rs 80.00% <100.00%> (-1.36%) ⬇️
core/src/network/stream.rs 77.56% <100.00%> (+0.29%) ⬆️
core/src/state.rs 82.40% <100.00%> (+2.61%) ⬆️
transports/net/src/lib.rs 76.71% <100.00%> (+1.45%) ⬆️
transports/quic/src/lib.rs 75.00% <100.00%> (+0.93%) ⬆️
transports/quic/src/processor.rs 65.82% <85.71%> (+0.88%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11ad62...ac132fb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant