Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update x11-clipboard to 0.9.1 #67

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Update x11-clipboard to 0.9.1 #67

merged 2 commits into from
Feb 2, 2024

Conversation

fornwall
Copy link
Contributor

@fornwall fornwall commented Jan 29, 2024 •
edited
Loading

This updated the minimum supported rust version on X11 from 1.65 to 1.66.

If possible, it would be nice to publish a minor release with this update, as it resolves some duplicated dependencies when using copypasta together with latest winit 0.29.

@fornwall fornwall mentioned this pull request Jan 29, 2024
Open
26 tasks
@fornwall fornwall force-pushed the update-x11-clipboard branch from 676887a to 7a8d315 Compare January 29, 2024 23:34
@fornwall
Copy link
Contributor Author

This updated the minimum supported rust version on X11 from 1.65 to 1.66.

Actually, due to an issue the current MSRV is 1.74 - let's await quininer/x11-clipboard#47 fixing that.

@fornwall fornwall force-pushed the update-x11-clipboard branch from 7a8d315 to 98a94cd Compare January 30, 2024 13:12
@fornwall fornwall changed the title Update x11-clipboard to 0.9.0 Update x11-clipboard to 0.9.1 Jan 30, 2024
@fornwall
Copy link
Contributor Author

Actually, due to an issue the current MSRV is 1.74 - let's await quininer/x11-clipboard#47 fixing that.

That has now been resolved and release, and this PR is ready for review @chrisduerr.

@chrisduerr chrisduerr requested a review from kchibisov January 30, 2024 14:44
chrisduerr
chrisduerr requested changes Jan 30, 2024
View reviewed changes
.builds/freebsd.yml Show resolved Hide resolved
@kchibisov
Copy link
Member

Well, I can't really test myself, so it's up to you @chrisduerr .

@chrisduerr
Copy link
Member

Well, I can't really test myself, so it's up to you @chrisduerr .

Just requested your review in case you're aware of anything noteworthy with this release.

@kchibisov
Copy link
Member

They will remove the last duplicate from alacritty deps ¯_(ツ)_/¯ and also fixed something.

@fornwall fornwall force-pushed the update-x11-clipboard branch from 98a94cd to a7a44b5 Compare January 30, 2024 16:03
@fornwall
Copy link
Contributor Author

They will remove the last duplicate from alacritty deps ¯_(ツ)_/¯ and also fixed something.

Removing duplicated dependencies was the main driver for us as well. Though getting quininer/x11-clipboard#46, a fix for a connection leak that was seen, is also nice.

@fornwall fornwall requested a review from chrisduerr January 30, 2024 16:06
@chrisduerr chrisduerr merged commit ec2b0f5 into alacritty:master Feb 2, 2024
4 checks passed
@fornwall fornwall deleted the update-x11-clipboard branch February 2, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchibisov kchibisov kchibisov approved these changes

@chrisduerr chrisduerr chrisduerr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fornwall @kchibisov @chrisduerr