Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop lodash #96

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Jul 8, 2024

eslint-plugin-autofix doesn't use lodash at all while eslint-plugin-web only uses lodash.escapeRegexp (which can be replaced w/ a single package without whole megabytes of lodash).

The PR drops lodash.

Copy link
Owner

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit 4f9edc2 into aladdin-add:master Jul 8, 2024
6 checks passed
@SukkaW SukkaW deleted the drop-lodash branch July 10, 2024 13:57
@SukkaW
Copy link
Contributor Author

SukkaW commented Sep 1, 2024

@aladdin-add Would mind releasing a newer version that includes this PR?

@aladdin-add
Copy link
Owner

This project is using release-please, by default refactor does not create new releases. I can push a new commit (fix) to trigger the release of a patch version, but more curious what you need it for?🤔

@SukkaW
Copy link
Contributor Author

SukkaW commented Sep 2, 2024

more curious what you need it for?🤔

Just reduce my node_modules size. eslint-plugin-autofix is the last dependency that introduces lodash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants