Fix: throw an error when disable a non-existent rule (fixes eslint#9505)

aladdin-add · Jul 5, 2018 · 4cbbf5c · 4cbbf5c
1 parent 704bcb0
commit 4cbbf5c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/config/config-validator.js b/lib/config/config-validator.js
@@ -118,8 +118,9 @@ function validateRuleSchema(rule, localOptions) {
  */
 function validateRuleOptions(rule, ruleId, options, source) {
     if (!rule) {
-        return;
+        throw new Error(`Definition for rule '${ruleId}' was not found.`);
     }
+
     try {
         const severity = validateRuleSeverity(options);
 

diff --git a/tests/lib/config/config-validator.js b/tests/lib/config/config-validator.js
@@ -303,6 +303,12 @@ describe("Validator", () => {
                 validator.validate({ rules: { "mock-rule": ["Error", "second"] } }, "tests", ruleMapper, linter.environments);
             });
 
+            it("should throw an error when the rule does not exist", () => {
+                const fn = validator.validate.bind(null, { rules: { "non-exsistent-rule": "off" } }, "tests", ruleMapper, linter.environments);
+
+                assert.throws(fn, "Definition for rule 'non-exsistent-rule' was not found.");
+            });
+
             it("should catch invalid rule options", () => {
                 const fn = validator.validate.bind(null, { rules: { "mock-rule": [3, "third"] } }, "tests", ruleMapper, linter.environments);